Replace deprecated Twig_NodeInterface with recommended Twig_Node

I'm on it.

I've rescaned the whole core and looked throuth all of places of using of Twig_NodeInterface class. Because just the Twig_Node class extends this interface, i think in all of place when used the parent class we can use the implemented class, and the Twig_NodeIntercase will be deprecated we have to use the Twig_Node in all of our codes. This patch replaces all of Twig_NodeInterface to Twig_Node in codes and documentations.

I think if the Twig_NodeInterface class is a deprecated that means the concrate calls of this will be wrong if once will be deleted, so we have to modify the code not just in the drupal core but in assetics and the twig classes, otherwise our patches will be failed. So i think the comment #5 is a good solution for that problem.

@cosmicdreams is correct, the patch in #8 is indeed much closer to what we'd need in core to solve this issue. See also #2228743: Replace deprecated Twig_CompilerInterface, Twig_LexerInterface and Twig_ParserInterface with recommended classes.

8: 2194155_8.patch queued for re-testing.

Just want to note that these changes are included in #2568181: [META] Update to Twig 2.x in Drupal 9, so this might end up being a duplicate.

It might be a good novice task to just create a new patch (create a new patch, don't try to reroll) that applies and see what the testbot thinks (see if any tests fail). Just to see if we could commit this separately potentially. But just a forewarning that it's very possible nothing will get committed here. Even still it could be good practice for rolling patches :)

Making this a child issue of #2568181: [META] Update to Twig 2.x in Drupal 9 per #2568181-45: [META] Update to Twig 2.x in Drupal 9.

The only problem with the changes in drupal/core/lib/Drupal/Core/Template/TwigNodeVisitor.php which implements an interface that expects Twig_NodeInterace to type the variables used in enterNode() and leaveNode()

Then I guess it should be moved to needs work.

This is almost certainly RC target per #2568181-45: [META] Update to Twig 2.x in Drupal 9, back to 8.0.x.

+++ b/core/lib/Drupal/Core/Template/TwigNodeVisitor.php
@@ -51,7 +51,8 @@ public function leaveNode(\Twig_NodeInterface $node, \Twig_Environment $env) {
-        // Store that we have a filter active already that knows how to deal with render arrays.
+        // Store that we have a filter active already that knows how to deal
+        // with render arrays.

Out of scope change, please remove. Thanks!

1. +++ b/core/lib/Drupal/Core/Template/TwigNodeVisitor.php
   @@ -16,19 +16,19 @@
   -class TwigNodeVisitor implements \Twig_NodeVisitorInterface {
   +class TwigNodeVisitor implements \Twig_BaseNodeVisitor {
   

   Shouldn't this be 'extends' instead of 'implements'? \Twig_BaseNodeVisitor is an abstract class, not an interface.

2. +++ b/core/lib/Drupal/Core/Template/TwigNodeVisitor.php
   @@ -16,19 +16,19 @@
   -  public function enterNode(\Twig_NodeInterface $node, \Twig_Environment $env) {
   +  public function doEnterNode(\Twig_Node $node, \Twig_Environment $env) {
   ...
   -  public function leaveNode(\Twig_NodeInterface $node, \Twig_Environment $env) {
   +  public function doLeaveNode(\Twig_Node $node, \Twig_Environment $env) {
   

   We should be changing these to protected methods per the interface.

Thanks for tagging this for rc target triage! To have committers consider it for inclusion in RC, add a statement to the issue summary of why we need to make this change during RC, including what happens if we do not make the change and what any disruptions from it are. You can add a section <h3>Why this should be an RC target</h3> to the summary.

In this case, it can probably just quote @effulgentsia's comment on the other issue. :)

Thanks @xjm!

This covers #24 and #27.1
@Cottser can you clarify #27.2? Thanks.

Just summarizing some discussion from IRC here for reference:

The \Twig_BaseNodeVisitor base class makes enterNode and leaveNode from the interface that we were previously implementing final to make sure that the nodes passed in are instances of \Twig_Node and then calls doEnterNode and doLeaveNode respectively. So when we extend that base class we are implementing the do* methods and those are protected on the base class so it makes sense to keep them protected.

Hopefully that makes some sense, it's late.

Thanks @Cottser ;)

Thanks @subhojit777, this looks good now! Updates all our usages and doesn't touch vendor.

@catch and I agree we should be ready for Twig 2.0

Committed 65dd859 and pushed to 8.0.x. Thanks!