Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"

Related to #1916134: Remove module_* deprecated functions

With the exception of a function_exists() call, all references to module_implements, module_hook and module_list were removed from core by August 2013. The functions themselves should now be removed.

CommentFileSizeAuthor
#21 remove-2193623-21.patch1.09 KBLinL
#19 remove-2193623-19.patch1.11 KBJeroenT
#10 drupal-2193623-8.patch1.11 KBshumer
#1 drupal-2193623-1.patch2.11 KBianthomas_uk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented
Status: Active » Needs review
Related issues: +#1916134: Remove module_* deprecated functions
FileSize
drupal-2193623-1.patch2.11 KB

Here's a patch. My laptop seems to be broken, so I'll test it myself this evening.

Status: Needs review » Needs work

The last submitted patch, 1: drupal-2193623-1.patch, failed testing.

The last submitted patch, 1: drupal-2193623-1.patch, failed testing.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented
Status: Needs work » Postponed

Oh great, drush depends on module_implements(). We'll need to fix that first.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented

This is postponed on https://github.com/drush-ops/drush/issues/452

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented

uh, i missed this issue, and posted a patch to remove all module_* deprecated function in #1916134: Remove module_* deprecated functions but had the same problem

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Postponed » Active

That drush issue is closed now.

Status: Active » Needs review

shumer queued 1: drupal-2193623-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: drupal-2193623-1.patch, failed testing.

shumer’s picture

shumer CreditAttribution: shumer commented
Issue tags: -@deprecated +#amsterdam2014, +sprint Amsterdam2014
FileSize
drupal-2193623-8.patch1.11 KB

Updated patch for test.

shumer’s picture

shumer CreditAttribution: shumer commented
Status: Needs work » Needs review

Status update

Status: Needs review » Needs work

The last submitted patch, 10: drupal-2193623-8.patch, failed testing.

Status: Needs work » Needs review

undertext queued 10: drupal-2193623-8.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 10: drupal-2193623-8.patch, failed testing.

shumer’s picture

shumer CreditAttribution: shumer commented
Issue tags: +Amsterdam2014

Patch still fails to run trough test on drush. Looks like drush issue still not applied to git.

oenie’s picture

oenie CreditAttribution: oenie commented
Issue tags: -#amsterdam2014, -sprint Amsterdam2014

fixing the amsterdam sprint tag to amsterdam2014

Status: Needs work » Needs review

ianthomas_uk queued 10: drupal-2193623-8.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 10: drupal-2193623-8.patch, failed testing.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Needs work » Needs review
FileSize
remove-2193623-19.patch1.11 KB
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Title: Remove module_implements, module_hook and module_list » Remove module_implements and module_list
Issue summary: View changes

module_hook is already removed. + Assigned to the following CR: Module/hook system functions replaced with module_handler and module_installer service

LinL’s picture

LinL CreditAttribution: LinL commented
Issue tags: +@deprecated
FileSize
remove-2193623-21.patch1.09 KB

Reroll following #2330181: Remove bootstrap.inc module_invoke().

Status: Needs review » Needs work

The last submitted patch, 21: remove-2193623-21.patch, failed testing.

Status: Needs work » Needs review

JeroenT queued 21: remove-2193623-21.patch for re-testing.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented

Random failure in Drupal\simpletest\Tests\MissingCheckedRequirementsTest : Allowed memory size of 335544320 bytes exhausted (tried to allocate 1698442 bytes)

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Needs review » Reviewed & tested by the community

Test pass, no occurrences left, CR was added -> RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Beta evaluation is in the issue summary. Committed 4709679 and pushed to 8.0.x. Thanks!

  • alexpott committed 4709679 on 8.0.x 
    Issue #2193623 by JeroenT, ianthomas_uk, shumer, LinL: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.