Updated: Comment #12
No page title on manage display & form for non-default view mode
No manage form display title
No manage display title
for the display, structure >> article will work.
for the form display, use the configuration >> account settings, and in the fieldset CUSTOM DISPLAY SETTINGS, enable the register form mode. (admin/config/people/accounts/form-display)
give them titles
review done.
no more tasks.
No.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | manage-form-people.png | 382.8 KB | yesct |
| #12 | manage-display-article.png | 398.21 KB | yesct |
| #2 | 2193609-2.patch | 4.02 KB | andypost |
| #2 | 2193609-2-fail.patch | 2.87 KB | andypost |
| manage_form.png | 13.75 KB | andypost |
Comments
Comment #1
andypostComment #2
andypostTest could not install node module, so no collisions with #1541298: Remove Node module dependency from Testing profile
Comment #3
andypostComment #5
larowlanLooks the goods
Comment #6
tim.plunkettThis is not just this page. admin/appearance/settings/bartik is another example.
When using hook_menu(), unless a title was specified, it would use the parent. We apparently relied on this in many places.
We might want to have a more general fix, or if not, a more concerted effort to check page titles throughout core.
Comment #7
andypostNice idea, filed #2194843: [meta] Write tests to make sure that pages have titles but current test for field_ui RouterSubscriber was incomplete and could be used as example.
Otoh it make sense to leave this task for some sprint and split on per module basis
Comment #8
catchHmm #6 makes this sound like a regression in the menu link/routing system. I think we should discuss whether it's worth trying to add some kind of title fallback back in vs. fixing these individually.
Comment #9
dawehnerThe path breadcrumb builder uses the last bit of the path, so "/foo/example/bar" returns "Bar" as title in the breadcrumb. We could apply the same logic here.
Added an issue which fixes most other instaces as well.
Comment #10
andypostField UI does not use
hook_menu()so this issues should be fixed itselfComment #11
swentel commentedYeah, let's fix this one here, it has some nice new tests too.
Comment #12
yesct commentedadded after screenshots.
Also noticed that for content types, the default mode is first, but for user it's not. opened #2203835: Make default form display and display mode be first secondary tabs
looks good to me also.
Comment #13
alexpottCommitted 228fdcb and pushed to 8.x. Thanks!
Comment #14
yesct commentedthe change from node to the account settings fields for this test might have caused #2203271: Undefined index "rows_order" in theme_field_ui_table()