I'm so glad about the watchdog backtrace.

Today i experienced a WSOD issue which i could hunt down to this module:
It was a simple notice somewhere in themeland. In the backtrace was a big html dump as argument which was printed all the way down and resulted in a log message of 60MB. Which seemed to crash something (probably the sqlite database).

CommentFileSizeAuthor
#3 backtrace_causes_wsod-2193481-3.patch8.54 KBmglaman
#2 commerce_devel-2193481-1-Backtrace-causes-WSOD.patch1.57 KBgeek-merlin

Comments

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

I think we should add a log message trim with a default of, say, 1mb.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Active » Needs review
StatusFileSize
new commerce_devel-2193481-1-Backtrace-causes-WSOD.patch1.57 KB

Patch flying in that truncates strings to a configurable limit.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new backtrace_causes_wsod-2193481-3.patch8.54 KB

I'd rather just remove the whole thing. I don't get why this module would overwrite Drupal's default error handler. That's not the purpose of the module. It's from the initial commit and should have gone into its own project.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Yeah, that belongs more in a "EMW devel" http://cgit.drupalcode.org/commerce_devel/commit/?id=4a69bbc73e4723adca0...

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

+1 for removing it, not sure how much benefit it brings. Devel can deal with the error handler if it needs to.

  • mglaman committed c566437 on 7.x-1.x 
    Issue #2193481 by axel.rutz, mglaman: Backtrace causes WSOD
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vadym.kononenko’s picture

vadym.kononenko commented

I like this error handler so, I've put it as sub-module to the package: system_extra.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Title: Backtrace causes WSOD » Link to Printable Backtrace
Component: Code » Documentation
Status: Closed (fixed) » Active

I have made this a full project which also integrates with Rules Debug:
Printable Backtrace (pbt) | Drupal.org

@vadym.kononenko: I didn't have read your post about your sandbox then, but if you have contributions and want to join forces, feel invited to co-maintain!

Re-opening this as a documentation issue, so a maintainer can put a link onto the project page.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: Link to Printable Backtrace » Backtrace causes WSOD
Component: Documentation » Code
Status: Active » Closed (fixed)

Please create a new issue as a follow up.

Changing existing issues is confusing. You can cross link through issue relationships