Updated: Comment #0

Problem/Motivation

The 'place block' links on the block page used to use dialogs but don't anymore

Proposed resolution

Fix it

Remaining tasks

Review attached patch
Decide how we can test this (answer might be we don't have JavaScript testing so move on).

User interface changes

Dialog to add blocks returns

API changes

Nada

CommentFileSizeAuthor
#2 2193425-2.patch390 bytesjibran
block-modals.1.patch775 byteslarowlan

Comments

nod_’s picture

nod_
Primary language French
Location Lille
commented

Why not make drupal.ajax a dependency of drupal.block.admin?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new 2193425-2.patch390 bytes

Fair point.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Manually tested this before and after the patch; the "configure block" dialog opens correctly with the patch applied. Not sure how we would add a test for this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 3d24d1b and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.