Problem/Motivation

All of the functions in config.inc are deprecated.

Postponed on #2188595: Create a ConfigManager to be able to remove config.inc

Proposed resolution

Remove usages of these functions and remove config.inc inclusion

Remaining tasks

Write patch

User interface changes

None

API changes

None

Files: 
CommentFileSizeAuthor
#7 2192693.7.patch35.1 KBswentel
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 64,729 pass(es). View
#5 2192693.5.patch33.4 KBswentel
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2192693.5.patch. Unable to apply patch. See the log in the details link for more information. View
#4 2-4-interdiff.txt3.29 KBalexpott
#4 2192693.4.patch32.35 KBalexpott
PASSED: [[SimpleTest]]: [MySQL] 64,365 pass(es). View
#2 2192693.2.patch28.61 KBalexpott
FAILED: [[SimpleTest]]: [MySQL] 64,146 pass(es), 215 fail(s), and 102 exception(s). View

Comments

alexpott’s picture

Status: Postponed » Active
Issue tags: +beta target
alexpott’s picture

Status: Active » Needs review
FileSize
28.61 KB
FAILED: [[SimpleTest]]: [MySQL] 64,146 pass(es), 215 fail(s), and 102 exception(s). View

Removing all the usages of config(), config_typed(), config_get_storage_names_with_prefix()

Status: Needs review » Needs work

The last submitted patch, 2: 2192693.2.patch, failed testing.

alexpott’s picture

Status: Needs work » Needs review
FileSize
32.35 KB
PASSED: [[SimpleTest]]: [MySQL] 64,365 pass(es). View
3.29 KB

Okay abstract static interesting-ness... fixed.

Removed config.inc and created https://github.com/drush-ops/drush/pull/463 to ensure Drush will continue to work.

swentel’s picture

FileSize
33.4 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2192693.5.patch. Unable to apply patch. See the log in the details link for more information. View

rerolled

Status: Needs review » Needs work

The last submitted patch, 5: 2192693.5.patch, failed testing.

swentel’s picture

Status: Needs work » Needs review
FileSize
35.1 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 64,729 pass(es). View

urgh

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

This looks good. config_typed() has no helper method, but it's only very rarely used so that's fine.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

https://drupal.org/node/2193603 needs an update.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.