Problem/Motivation

All of the functions in config.inc are deprecated.

Postponed on #2188595: Create a ConfigManager to be able to remove config.inc

Proposed resolution

Remove usages of these functions and remove config.inc inclusion

Remaining tasks

Write patch

User interface changes

None

API changes

None

CommentFileSizeAuthor
#7 2192693.7.patch35.1 KBswentel
#5 2192693.5.patch33.4 KBswentel
#4 2-4-interdiff.txt3.29 KBalexpott
#4 2192693.4.patch32.35 KBalexpott
#2 2192693.2.patch28.61 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Postponed » Active
Issue tags: +beta target

#2188595: Create a ConfigManager to be able to remove config.inc is in.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Active » Needs review
FileSize
2192693.2.patch28.61 KB

Removing all the usages of config(), config_typed(), config_get_storage_names_with_prefix()

Status: Needs review » Needs work

The last submitted patch, 2: 2192693.2.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs work » Needs review
FileSize
2192693.4.patch32.35 KB
2-4-interdiff.txt3.29 KB

Okay abstract static interesting-ness... fixed.

Removed config.inc and created https://github.com/drush-ops/drush/pull/463 to ensure Drush will continue to work.

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
2192693.5.patch33.4 KB

rerolled

Status: Needs review » Needs work

The last submitted patch, 5: 2192693.5.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review
FileSize
2192693.7.patch35.1 KB

urgh

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

This looks good. config_typed() has no helper method, but it's only very rarely used so that's fine.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

https://drupal.org/node/2193603 needs an update.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.