When user follows tour instructions, they are taken off the tour!

Patch is attached! Please let me know what you think.

I haven't tried "reflex" mode, but looking at the docs, it seemed that was meant for tours that stay on the same page. We can try it!

But also, we don't necessarily know that the users will get to the next page by clicking the element. For example, if it's a content creation form and we're are pointing at the "Title" element (or some other random bit of the form) and the user goes all the way to submit the form, we should take them to the step that is on the following page, regardless of it they clicked the element or not. So, it's about catching up with the user when they showed initiative and did what the tour said, but that can go off the current page.

Thanks! Sorry, I never got around to testing 'reflex' but I still plan to! I suspect it won't make sense to be on by default, but it might be useful as an option you can select for some steps. I'll need to mod-up some real tours (probably the OA tours) and see it in practice, though. :-)

This is has been working for me on Open Atrium with the tours it bundles. I haven't done much testing outside of that context, though.

Can you create a Feature which has one of your problem tours (or minimal steps to create a problem tour) and give the steps to reproduce?

Since I created the original patch, I feel responsible for getting to work right. :-)

I talked with Mike Potter today about a reproducible case where tours would start unexpected when using a single site that accessible at multiple domains. Since it's reproducible, I'll look into when I have a chance - new issue here: #2207737: Tours unexpected return on sites with multiple domains

@spazfox: Since I can't reproduce your problems, there's nothing I can do. However, if you post steps to reproduce, I'd be happy to take a look!

Er, I didn't realize that this was actually reverted in Git! I just assumed Mike was reverting OA to an older version. In that case, my new issue doesn't actually make sense, and I'll work on it in this issue.

Here's the information I had put on that:

Let's say that, for example, you have a site that's accessible at both:

• sub1.example.com
• sub2.example.com

... and your tour takes from from sub1.example.com to sub2.example.com, it will initiate a new tour at sub2.example.com, but leave the old tour running on sub1.example.com. When users return to sub1.example.com it'll try to redirect them back to the tour, even if they finished it on sub2.example.com.

I'm not entirely sure the best way to deal with this, but I discussed some possibilities with Mike Potter. Here's some stuff I definitely want to try:

• Syncing the "tour state" between Javascript and backend. Bootstrap tour stores whether a tour is still running in window.localStorage (which is per-domain!) and we also store it in the session. When a tour is ended, we should make an AJAX call to the server to end it in the session as well. This won't fix that stale data could be on window.localStorage for some domain, but it would prevent us from starting a tour that previously finished on another domain.
• Prevent URL intiation of tours when it's not on step=1 and the session has no previous record of the tour. When you cross-domains in the middle of a tour, it'll start you on some step in the middle (ie. path?tour=tour&step=4). This would work fine, if the user has configured $cookie_domain so that sessions are stored across domains, but will create problems if not. We can store the domain used when starting the tour and detect if they have $cookie_domain setup properly.

Anyway, not sure what will work in the end, but I have some place to start!

Well, switching between HTTP and HTTPS would have the same effect as switching domains would. But since you're not doing that, there really isn't anything about being on HTTPS that could have an effect. The main site I'm using this patch on is also HTTPS only, and there are no problems. :-/ Anyway, I'll look into the issues Mike Potter found soon and maybe (if we're lucky!) it'll fix your problems too. :-)

Ok, here is an attempt to fix the issues that Mike Potter found. Mike can you try this with your use case? I was able to reproduce lots of weirdness with multiple domains, but not the exact system/ajax Javascript error that you had... If it's still present I may need some more info on reproducing it.

I've also included an interdiff too so you can see what I added.

@spazfox: If you have the time to test and see if this has any affect on your problems, that'd be nice too!

There are still some issues with my patch for tours with only one step (like the "Welcome to OA2" tour). I'll make a fix soon!

Ok! I've got a new patch that fixes a number of things:

• Tours with only one step
• Tours that have a later step that is on the same path as the first step
• Correctly detecting the path of the next step, when it's on the same page (and so doesn't include a path in it's definition)

The new patch is attached along with an interdiff from the last one!

I also found a number of weird problems with the Open Atrium tours, which turned out to be problems with those tours themselves - see these PRs for an explanation and fix (already merged):

https://github.com/phase2/oa_core/pull/59
https://github.com/phase2/oa_core/pull/60

At this point, my patch works for me with all the Open Atrium tours AND allows you to actually follow the tour instructions WITHOUT losing the tour! It also doesn't have any problems I can reproduce with multiple domains.

Please review when you have a chance!

Ah, sorry, I uploaded the wrong patches! :-/ These should be the correct ones. Please just ignore the patches on #17, those were from yesterday before I discovered some of the problems mentioned in that comment.