[D7] Percentage Scale

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxtcalin2189449git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Status should either be the status it was in when it was closed (i.e. "Needs work"), or "Needs review" if the work is done and it is ready for a new review.

Note that it will be automatically closed again if you haven't addressed the known problems in 70 days after reopening.

Below is a summary of known problems.

1. The automated review of your project by PAReview has found some issues with your code. As coding standards make sure projects are coded in a consistent style we ask you to please have a look at the report and try to fix them.
2. It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
3. There is no git clone command in your issue summary. Make sure there is one.
4. Please take a moment to make your project page follow tips for a great project page.
5. Please take a moment to make your README.txt follow the guidelines for in-project documentation and the README.txt Template.
6. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. It looks like what this module can be be fitted into ImageCache Actions.

   As one already can use ImageCache Actions with a custom script to do percentage scaling ...

   image_gd_resize($image,$image->info['width']*0.5,$image->info['height']*0.8);
   return $image; 
   

   ... I don't see why we need a whole module for this.

   Please open an issue in ImageCache Actions. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

   If that fails for whatever reason please get back to us and set this back to "needs review".

You should specify that ImageCache Actions is a requirement on your project page and in your readme.txt.

I just wanted to say that I downloaded your sandbox project to use on a website I am building. I found the project very useful and easy to use. I think responsive image sizes is now almost expected on all websites nowadays and perhaps it will be added to Image Cache Actions at some point. In the meantime your project is very useful. Thank you.

@gisle - I completely understand your point of view on this, however I am a non-coder and would have really struggled to create the custom script you did, so was very glad to find this project.

This is such a useful project I would say it would be worth adding as a full project, not just a sandbox, if only until Image Cache Actions look at incorporating this functionality?

BTW I tried using the git clone link, and it didn't work for me. I got on error saying something like "file or directory not found", so I just copied and pasted the code for each of the files.

Many thanks for the project again.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.