Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Updated: Comment #N
Problem/Motivation
We have a views_view_has_form_elements() method that we pass the view into to determine if it has form elements. This should be something we ask the view for.
Proposed resolution
Add a hasFormElements() method to ViewExecutable, move the same logic into there instead.
Remaining tasks
User interface changes
None
API changes
Removal of views_view_has_form_elements() method, although this is basically internal to views.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 2190183-6.patch | 2.63 KB | damiankloip |
| vdc.hasFormElement.patch | 2.59 KB | damiankloip |
Comments
Comment #2
damiankloip commentedStupid HEAD.
Comment #3
damiankloip commentedvdc.hasFormElement.patch queued for re-testing.
Comment #4
dawehnerPerfect!
Comment #5
alexpottvdc.hasFormElement.patch no longer applies.
Comment #6
damiankloip commentedComment #8
damiankloip commented6: 2190183-6.patch queued for re-testing.
Comment #9
dawehnerBack to rtbc.
Comment #10
alexpottCommitted 0b760b1 and pushed to 8.x. Thanks!
Assigning back to views queue for a change record.
Comment #11
chris matthews commentedFor more information as to why this issue was moved to the Drupal core project, please see issue #3030347: Plan to clean process issue queue
Comment #12
chris matthews commentedMoving back to the contributed Views issue queue and closing as outdated per https://www.drupal.org/project/views/issues/3030347#comment-13023447