Updated: Comment #N

Problem/Motivation

We have a views_view_has_form_elements() method that we pass the view into to determine if it has form elements. This should be something we ask the view for.

Proposed resolution

Add a hasFormElements() method to ViewExecutable, move the same logic into there instead.

Remaining tasks

User interface changes

None

API changes

Removal of views_view_has_form_elements() method, although this is basically internal to views.

CommentFileSizeAuthor
#6 2190183-6.patch2.63 KBdamiankloip
vdc.hasFormElement.patch2.59 KBdamiankloip

Comments

Status: Needs review » Needs work

The last submitted patch, vdc.hasFormElement.patch, failed testing.

damiankloip’s picture

damiankloip commented

Stupid HEAD.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review

vdc.hasFormElement.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

vdc.hasFormElement.patch no longer applies.

error: patch failed: core/modules/views/views.theme.inc:130
error: core/modules/views/views.theme.inc: patch does not apply
damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2190183-6.patch2.63 KB

Status: Needs review » Needs work

The last submitted patch, 6: 2190183-6.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review

6: 2190183-6.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Back to rtbc.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Replace views_view_has_form_elements() with a hasFormElements() method on ViewExecutable » Change record: Replace views_view_has_form_elements() with a hasFormElements() method on ViewExecutable
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Documentation
Status: Reviewed & tested by the community » Active
Issue tags: +API change, +Approved API change, +Missing change record

Committed 0b760b1 and pushed to 8.x. Thanks!

Assigning back to views queue for a change record.

chris matthews’s picture

chris matthews commented
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.7.x-dev
Component: Documentation » views.module

For more information as to why this issue was moved to the Drupal core project, please see issue #3030347: Plan to clean process issue queue

chris matthews’s picture

chris matthews commented
Project: Drupal core » Views (for Drupal 7)
Version: 8.7.x-dev » 7.x-3.x-dev
Component: views.module » Code
Status: Active » Closed (outdated)

Moving back to the contributed Views issue queue and closing as outdated per https://www.drupal.org/project/views/issues/3030347#comment-13023447