Fatal error: Call to a member function hasPath() on a non-object in ViewListController::getDisplayPaths()

We should at least write something to the watchdog if a display on the actual frontend does not exists,
as hiding this fact is a bad idea.

Maybe we should also try to skip invalid plugins on the iterator.

First of all, good find!

Not caused by a missing module dependency.

It kind of is, the actual fatal is not coming from the 'test_display_feed' view, but from the 'content_recent' view in the test. The block module is not enabled, but node is is. And the content_recent view has configuration for a view display.

I think this needs to be fixed in the actual pluginBag class, otherwise you will need to check for this every time you iterate over some plugin bag class.

I think something like this. Not sure if this is best, as get() will get called again but checking anything in current() is too late, so valid() makes the most sense from that point of view. This is only during iteration too, we lose nothing on single get() calls.

EDIT: Oh, didn't realise Daniel just posted here too (just looked at comment number and posted patch). Seems he had a similar idea of where the fix should live.

Ok, no worries :) let me fix the remaining tests.

OK, let's see how this gets on.

It was indeed a bogus test - The setupPluginBag method was creating a value map to return the plugin. However, because the setConfiguration method was changing the configuration data for that plugin, the plugin map did not match both parameters anymore, so returned NULL. I have switched this to use a returnCallback instead.

Parenthesis weren't necessary but I tend to favour that, as visually it is easier to follow the conditions. Anyway, meh - I've reverted that change :)

12: 2189453-12.patch queued for re-testing.

Seems like another random one (UserCancelTest).

+1 for checking on this level.

Catch asked for this one to be split off, so assigning to him.

+++ b/core/lib/Drupal/Component/Plugin/PluginBag.php
@@ -161,7 +161,11 @@ public function key() {
+    return $key !== NULL && $key !== FALSE && $this->get($key);

This needs a @todo to remove when #2080823: Create API to discover config entities' soft dependencies and use this to present a confirm form on module uninstall is fixed. Silently eating errors like this makes for horrible debugging. Otherwise patch looks OK.

@todo added.

Committed/pushed to 8.x, thanks!