Closed (fixed)
Project:
Panels
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Feb 2014 at 02:47 UTC
Updated:
2 Jan 2015 at 02:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
costinius commentedUpdate: I am not an expert at php errors, but it has something to do with user permissions. If I allow a user to "Configure access settings on Panel panes", "Configure caching settings on Panels", and "Use panel locks", the error disappears.
Comment #2
costinius commentedI think I've got to the bottom of the issue. Basically, if a user doesn't have the rights mentioned in the comment above, the $links[] array does not get the keys 'visibility', 'lock', 'cache' etc. However, in line 481 the code runs through these keys anyway and that causes an issue.
So, I've changed the code a bit to check whether these keys exist in the array by adding the following instruction:
if (array_key_exists($category, $links))and the whole code now looks like (starting line 469):
Comment #3
chris burge commentedI ran across these same errors, which led me to this issue. My testing confirms the three permissions you identified. Changing the code in panels_renderer_editor.class.php as you suggest fixes the errors for me. Attached is a patch created from #2.
Comment #4
chris burge commentedComment #5
xaa commentedpatch working. thank you.
Comment #6
bradjones1Needs code formatting fixes at the very least.
Comment #7
johnnydarkko commentedRerolled the patch to follow drupal coding standards.
Thanks for the patch, Chris Burge! Works great for me too!
Comment #8
johnnydarkko commentedDarn... forgot a comma.
Comment #9
chris burge commentedTesting of #8 patch was successful. Thanks @johnnydarkko.
Comment #10
johnnydarkko commentedComment #11
d0t15t commentedpatch #8 works for me.
Comment #12
axroth commentedpatch #8 works for me as well.
Comment #13
jackalope commentedThe patch in #8 works for me as well. Thanks so much!
Comment #14
danepowell commentedYep, #8 works.
Comment #15
weri commentedPatch #8 works for me also.
Comment #16
pietrocap commentedPatch #8 woks, even if applied to 7.x-3.4
Comment #17
func0der commentedMerge, merge, merge! :D
Comment #18
japerryThanks for the testing, committed to dev.