It saves all values as null.

Comments

ultimike’s picture

Project: IMP » Drupal core
Version: » 8.x-dev
Component: Code » migration system
Parent issue: » #2223795: Manual Testing: Taxonomy terms

Is this still an issue? Would you mind re-testing?

Thanks,
-mike

ultimike’s picture

Also - need to confirm that we have automated tests for these variables.

-mike

densolis’s picture

Assigned: penyaskito » densolis

I will work on this issue.

Figure out where the following fields are exposed on D6.

- taxonomy_override_selector
- taxonomy_terms_per_page_admin

I need to change the value for these fields in D6 somehow, run the migration and then see if the following fields on D8 were changed:

override_selector: taxonomy_override_selector
terms_per_page_admin: taxonomy_terms_per_page_admin

D8 Configuration - Configuration Management -> Single Import Export -> config_name: taxonomy.settings

densolis’s picture

Title: d6_taxonomy_settings not working » Can not find where the two variables are set.

All,

I search the D6 database and the D6 code for the above two terms. Neither of the above above variable names were in the database.

I did find the variable name "taxonomy_terms_per_page_admin" in taxonomy.admin.inc:

  // taxonomy_get_tree and taxonomy_get_parents may contain large numbers of
  // items so we check for taxonomy_override_selector before loading the
  // full vocabulary. Contrib modules can then intercept before
  // hook_form_alter to provide scalable alternatives.
  if (!variable_get('taxonomy_override_selector', FALSE)) {
    $parent = array_keys(taxonomy_get_parents($edit['tid']));
    $children = taxonomy_get_tree($vocabulary->vid, $edit['tid']);

    // A term can't be the child of itself, nor of its children.
    foreach ($children as $child) {
      $exclude[] = $child->tid;
    }

I found the code where the variable taxonomy_terms_per_page_admin is referenced:

  $page_increment  = variable_get('taxonomy_terms_per_page_admin', 100);  // Number of terms per page.

But I can not find where it is set.

Here is the code for variable_get()

function variable_get($name, $default) {
  global $conf;
  return isset($conf[$name]) ? $conf[$name] : $default;
}

The next option is to dowload and search some of these D6 taxonomy modules (courtesy of lscook):

enabled), Taxonomy Notifications (enabled), Smartqueue taxonomy (disabled), Taxonomy breadcrumb (disabled), Taxonomy Manager (enabled), Taxonomy Role (enabled), Taxonomy Service (enabled), Taxonomy User (enabled), Vote Up/Down Terms (disabled), XML sitemap taxonomy (enabled), Advanced Forum (enabled), Calais Geo (disabled), Calais Tag Modifier (enabled),

densolis’s picture

Title: Can not find where the two variables are set. » Migrate two taxonomy variables

On my D6 site, I used the following commands to set the variables:

drush variable-set taxonomy_override_selector True
drush variable-set taxonomy_terms_per_page_admin 75

I then checked the "variable" table in the D6 database to make sure there were set.

On my D8 site, I have no taxonomy.

densolis’s picture

Status: Active » Closed (cannot reproduce)

oops, I did not enable migrate_drupal. I did that and ran the command:

drush migrate-manifest --legacy-db-url=mysql://drupaluser@127.0.0.1:33067/drupal6 D6Manifest-Taxonomy.yml

Running d6_taxonomy_settings [ok]
Running d6_taxonomy_vocabulary [ok]
Running d6_taxonomy_term [ok]

Please note that I had to put :33067 (mysql port number) in the command in order to have drush connect to the database.

On my D6 database, I set the:

- taxonomy_override_selector = True
- taxonomy_terms_per_page_admin = 75

I then ran the migration and exported the configuration via:

Configuration -> Development -> Configuration Management -> Single Export: Simple configuration and taxonomy.settings

The results are:
maintain_index_table: true
override_selector: true
terms_per_page_admin: 75

so the test worked.