Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
comment.module
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Feb 2014 at 22:18 UTC
Updated:
29 Jul 2014 at 23:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehneryeah I realized something similar on #2177041: Remove all implementations of hook_menu, not sure whether we want to merge the issues though.
Comment #2
alexpottCommitted 9d5d0ea and pushed to 8.x. Thanks!
Comment #3
alexpottUnfortunately this broke HEAD. Committed bfd1f63 and pushed to 8.x.
Undefined property: Drupal\menu_link\Entity\MenuLink::$menu_name
Drupal\menu_link\MenuLinkStorageController->save(Object) _menu_link_save_recursive(Object, 'comment.admin.content.comment', Array, Array) menu_link_rebuild_defaults() menu_router_rebuild() Drupal\Core\EventSubscriber\RouterRebuildSubscriber->onRouterRebuild(Object, 'routing.route_finished', Object) call_user_func(Array, Object, 'routing.route_finished', Object) Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(Array, 'routing.route_finished', Object) Symfony\Component\EventDispatcher\EventDispatcher->dispatch('routing.route_finished', Object) Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('routing.route_finished', Object) Drupal\Core\Routing\RouteBuilder->rebuild() drupal_flush_all_caches() Drupal\simpletest\WebTestBase->resetAll() Drupal\simpletest\WebTestBase->setUp() Drupal\comment\Tests\CommentNonNodeTest->setUp() Drupal\simpletest\TestBase->run() simpletest_script_run_one_test('80', 'Drupal\comment\Tests\CommentNonNodeTest')Notice MenuLinkStorageController.php 124 Drupal\menu_link\MenuLinkStorageController->save()

Undefined property: Drupal\menu_link\Entity\MenuLink::$menu_name Notice MenuLinkStorageController.php 124 Drupal\menu_link\MenuLinkStorageController->save()
Comment #4
alexpottComment #5
alexpottcomment-menu-link-defaults.patch queued for re-testing.
Comment #7
rcaracaus commentedcan't hang comment menu link off nod if node not enabled.
Comment #8
larowlanComment #9
larowlanGood job
Comment #10
xanoSee #2085571: admin/content should not depend on node.module for the root cause of this problem.
Comment #11
xanoAdded related issues.
Comment #12
andypostNext alpha released with this regression
Comment #13
andypostThis is a major UX failure because we can't add fields for comments
Comment #14
webchickLet's try that again.
Committed and pushed to 8.x. Thanks!