Steps to reproduce:
1. Install
2. Goto admin/structure
3. Click "Comment forms"

You are at admin/content/comment. You should be at admin/structure/comments.

CommentFileSizeAuthor
#7 2188097-7.patch1.04 KBrcaracaus
comment-menu-link-defaults.patch1004 bytesolli
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

yeah I realized something similar on #2177041: Remove all implementations of hook_menu, not sure whether we want to merge the issues though.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 9d5d0ea and pushed to 8.x. Thanks!

alexpott’s picture

Unfortunately this broke HEAD. Committed bfd1f63 and pushed to 8.x.

Test name	Pass	Fail	Exception
Drupal\comment\Tests\CommentNonNodeTest	166	0	2

Undefined property: Drupal\menu_link\Entity\MenuLink::$menu_name

Drupal\menu_link\MenuLinkStorageController->save(Object) _menu_link_save_recursive(Object, 'comment.admin.content.comment', Array, Array) menu_link_rebuild_defaults() menu_router_rebuild() Drupal\Core\EventSubscriber\RouterRebuildSubscriber->onRouterRebuild(Object, 'routing.route_finished', Object) call_user_func(Array, Object, 'routing.route_finished', Object) Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(Array, 'routing.route_finished', Object) Symfony\Component\EventDispatcher\EventDispatcher->dispatch('routing.route_finished', Object) Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('routing.route_finished', Object) Drupal\Core\Routing\RouteBuilder->rebuild() drupal_flush_all_caches() Drupal\simpletest\WebTestBase->resetAll() Drupal\simpletest\WebTestBase->setUp() Drupal\comment\Tests\CommentNonNodeTest->setUp() Drupal\simpletest\TestBase->run() simpletest_script_run_one_test('80', 'Drupal\comment\Tests\CommentNonNodeTest') 

Notice MenuLinkStorageController.php 124 Drupal\menu_link\MenuLinkStorageController->save()
Undefined property: Drupal\menu_link\Entity\MenuLink::$menu_name Notice MenuLinkStorageController.php 124 Drupal\menu_link\MenuLinkStorageController->save()

alexpott’s picture

Status: Fixed » Needs review
alexpott’s picture

comment-menu-link-defaults.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, comment-menu-link-defaults.patch, failed testing.

rcaracaus’s picture

FileSize
1.04 KB

can't hang comment menu link off nod if node not enabled.

larowlan’s picture

Status: Needs work » Needs review
larowlan’s picture

Status: Needs review » Reviewed & tested by the community

Good job

Xano’s picture

See #2085571: admin/content should not depend on node.module for the root cause of this problem.

Xano’s picture

andypost’s picture

Next alpha released with this regression

andypost’s picture

Priority: Normal » Major

This is a major UX failure because we can't add fields for comments

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Let's try that again.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.