Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
comment_int_to_alphadecimal
actually does the opposite, because it calls Number::alphadecimalToInt($i)
.
These functions are already deprecated (although only as of 7th Jan 2014, see #2157703: Deprecate comment_int_to_alphadecimal() & comment_alphadecimal_to_int() in favour of methods in Number component) and are not currently called by core, so rather than fixing let's just remove the functions.
Comment | File | Size | Author |
---|---|---|---|
#1 | comment-2187653-1-remove-alphadecimal.patch | 1.32 KB | ianthomas_uk |
Comments
Comment #1
ianthomas_ukComment #2
andypostI'd like to see this commited but that depends on #2042165: Add a 'deprecated' module that includes deprecated functions only when enabled
Comment #3
larowlanPlus 1
Comment #4
xjmI'm not sure this depends on #2042165: Add a 'deprecated' module that includes deprecated functions only when enabled -- elsewhere, these deprecated functions are being removed, as discussed in #2158871: [Policy, no patch] Clearly denote when @deprecated code is slated to be removed.
https://drupal.org/node/1439500 can be updated now, because the function is already deprecated.
Comment #5
catchCommitted/pushed to 8.x, thanks!
Comment #6
ianthomas_ukI've updated https://drupal.org/node/1439500 to point to the new methods and remove mention of comment_increment_alphadecimal, a new function which didn't last long.