comment_int_to_alphadecimal actually does the opposite, because it calls Number::alphadecimalToInt($i).

These functions are already deprecated (although only as of 7th Jan 2014, see #2157703: Deprecate comment_int_to_alphadecimal() & comment_alphadecimal_to_int() in favour of methods in Number component) and are not currently called by core, so rather than fixing let's just remove the functions.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ianthomas_uk’s picture

Status: Active » Needs review
FileSize
1.32 KB
andypost’s picture

Status: Needs review » Reviewed & tested by the community
Parent issue: » #2042165: Add a 'deprecated' module that includes deprecated functions only when enabled
larowlan’s picture

Plus 1

xjm’s picture

I'm not sure this depends on #2042165: Add a 'deprecated' module that includes deprecated functions only when enabled -- elsewhere, these deprecated functions are being removed, as discussed in #2158871: [Policy, no patch] Clearly denote when @deprecated code is slated to be removed.

https://drupal.org/node/1439500 can be updated now, because the function is already deprecated.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

ianthomas_uk’s picture

I've updated https://drupal.org/node/1439500 to point to the new methods and remove mention of comment_increment_alphadecimal, a new function which didn't last long.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.