comment_int_to_alphadecimal actually does the opposite, because it calls Number::alphadecimalToInt($i).

These functions are already deprecated (although only as of 7th Jan 2014, see #2157703: Deprecate comment_int_to_alphadecimal() & comment_alphadecimal_to_int() in favour of methods in Number component) and are not currently called by core, so rather than fixing let's just remove the functions.

CommentFileSizeAuthor
#1 comment-2187653-1-remove-alphadecimal.patch1.32 KBianthomas_uk

Comments

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Status: Active » Needs review
StatusFileSize
new comment-2187653-1-remove-alphadecimal.patch1.32 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community
Parent issue: » #2042165: Add a 'deprecated' module that includes deprecated functions only when enabled

I'd like to see this commited but that depends on #2042165: Add a 'deprecated' module that includes deprecated functions only when enabled

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Plus 1

xjm’s picture

xjm
she/her
Primary language English
commented

I'm not sure this depends on #2042165: Add a 'deprecated' module that includes deprecated functions only when enabled -- elsewhere, these deprecated functions are being removed, as discussed in #2158871: [Policy, no patch] Clearly denote when @deprecated code is slated to be removed.

https://drupal.org/node/1439500 can be updated now, because the function is already deprecated.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented

I've updated https://drupal.org/node/1439500 to point to the new methods and remove mention of comment_increment_alphadecimal, a new function which didn't last long.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.