Post Propagation Direction is behaving in a way that's confusing to me. I think it's a bug, but maybe I'm misunderstanding it :-)

I don't wish to have group posts propagated in either direction, so I set Post Propagation Direction = none.

This has the side effect of causing the module to ignore the Parents setting when I create a subgroup.

Setting Post Propagation Direction = "Up the tree" allows the Parent setting to be saved.

I did some digging around ... hopefully I'm not about to make a fool of myself:

In hook_nodeapi in V2.0, the parents of a subgroup were saved with:
   og_subgroups_save_parents($node->nid, $node->parents);

In 3.0-dev, it appears to be saved with:
   og_subgroups_save_family($node, variable_get('og_subgroups_prop_type', 'none'));

In function og_subgroups_save_family there's the following:

<?php
   if ($family_type == 'none') {
    return FALSE;
  } 
?>

I think some logic needs to be added to distinguish between group content nodes and subgroup nodes.

Thanks!

CommentFileSizeAuthor
#2 218747.patch2.37 KBezra-g

Comments

dale42’s picture

Title: Confusion around Post Propagation Direction » Parent not Saved when Post Propagation Direction set to None

Gave issue a better title

ezra-g’s picture

Status: Active » Needs review
StatusFileSize
new2.37 KB

Thanks for the troubleshooting, torelad! This patch could use some testing. I removed the

   if ($family_type == 'none') {
    return FALSE;
  }

from og_subgroups_save_family() and added a check in og_subgroups_get_family() to skip parent\child propagation when propagation direction is set to 'none' .

Propagation of og homepage nodes and non-og homepage nodes worked as desired for me with propagation set to 'none' and when set to 'parents' with these changes.

ezra-g’s picture

Assigned: Unassigned » ezra-g
Status: Needs review » Fixed

Fixed in 5.x.3.0 . Thanks to torelad for initial troubleshooting!

ezra-g’s picture

This was Commit #103127 .

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.