Missing close bracket and other issues that prevent {@inheritdoc} from being properly parsed.

CommentFileSizeAuthor
#7 core-2187063-7-inheritdoc-do-not-test.patch11.57 KBles lim
#3 core-2187603-inheritdoc-3-do-not-test.patch11.54 KBles lim
#1 core-2187603-inheritdoc-do-not-test.patch425 bytesles lim

Comments

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new core-2187603-inheritdoc-do-not-test.patch425 bytes

Patch attached.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

:)

les lim’s picture

les lim
he/they
Primary language English
commented
Title: @inheritdoc typo in \Drupal\Core\Theme\ThemeNegotiator » Fix @inheritdoc typos throughout core
Component: theme system » documentation
Priority: Minor » Normal
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new core-2187603-inheritdoc-3-do-not-test.patch11.54 KB

Actually, might as well fix all of them.

There are a bunch of @inheritdoc issues in vendor/ as well, but we're not touching those here.

les lim’s picture

les lim
he/they
Primary language English
commented
Issue tags: +Quick fix

Adding tag.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Nice cleanup

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: Unassigned » webchick
Issue tags: +Will cause commit conflicts

I agree the patch looks good, and thanks for making it!

However, throwing this one over to webchick because it touches a bunch of files and I'm not sure what the schedule is for making possibly disruptive commits.

les lim’s picture

les lim
he/they
Primary language English
commented
StatusFileSize
new core-2187063-7-inheritdoc-do-not-test.patch11.57 KB

Needed a re-roll, in any case.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

This time around, we were only going to do a major/critical only window for 2-3 days before alpha, which isn't until week after next (Feb 19). There's only one "avoid commit conflicts" patch atm but it's already been broken by 8,000 other things, so I think this is safe. If it breaks something critical, we can always roll it back and try again later.

Committed and pushed to 8.x. Thanks!

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +JavaScript

This changes a JS file. Tagging.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.