Missing close bracket and other issues that prevent {@inheritdoc} from being properly parsed.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | core-2187063-7-inheritdoc-do-not-test.patch | 11.57 KB | les lim |
| #3 | core-2187603-inheritdoc-3-do-not-test.patch | 11.54 KB | les lim |
| #1 | core-2187603-inheritdoc-do-not-test.patch | 425 bytes | les lim |
Comments
Comment #1
les limPatch attached.
Comment #2
aspilicious commented:)
Comment #3
les limActually, might as well fix all of them.
There are a bunch of @inheritdoc issues in vendor/ as well, but we're not touching those here.
Comment #4
les limAdding tag.
Comment #5
joelpittetNice cleanup
Comment #6
jhodgdonI agree the patch looks good, and thanks for making it!
However, throwing this one over to webchick because it touches a bunch of files and I'm not sure what the schedule is for making possibly disruptive commits.
Comment #7
les limNeeded a re-roll, in any case.
Comment #8
webchickThis time around, we were only going to do a major/critical only window for 2-3 days before alpha, which isn't until week after next (Feb 19). There's only one "avoid commit conflicts" patch atm but it's already been broken by 8,000 other things, so I think this is safe. If it breaks something critical, we can always roll it back and try again later.
Committed and pushed to 8.x. Thanks!
Comment #9
nod_This changes a JS file. Tagging.