Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
// And then we push the out the new changed timestamp to our denormalized
// tables.
db_update('tracker_node')
->fields(array(
'changed' => $changed,
'published' => $node->status,
))
->condition('nid', $nid)
->execute();
db_update('tracker_node')
->fields(array(
'changed' => $changed,
'published' => $node->status,
))
->condition('nid', $nid)
->execute();
}
}
There appears to be a redundant db_update in _tracker_remove. The second one supposed to apply to tracker_user if the module follows the same structure at the D6 verison. If this is not the case the second db_update probably should be eliminated as unnecessary. This should also be backported to D7.
I have no way of testing this on D8 (not yet familliar enough with D8).
Comment | File | Size | Author |
---|---|---|---|
#2 | tracker.module.patch | 518 bytes | letapjar |
Comments
Comment #1
letapjar CreditAttribution: letapjar commentedChecking the code from the D6 module Tracker 2 it appears as if the second db_update is infact supposed to be for tracker_user.
Comment #2
letapjar CreditAttribution: letapjar commentedComment #3
dawehnerThe patch itself looks pretty great.
Let's better adds some tests.
Comment #4
letapjar CreditAttribution: letapjar commentedI'm not sure how to do that as I'm not 100% familliar w/. what Tracker
Comment #6
tim.plunkettThis is still a problem.
Comment #8
andypost