As seen in the screenshot:

Main fieldset collapsed by default.

Fix is very simple: we just need #collapsed set to FALSE on that fieldset. #collapsed being set to TRUE by default only makes sense if it's coupled with the code at #2159813: Display parts of the issue edit form instead of the comment form on issue pages, which has yet to be deployed.

Fortunately, once you click to expand the fieldset you get it expanded by default from then on, but this is still a pretty big UX regression, so labeling as major.

CommentFileSizeAuthor
Screen Shot 2014-01-30 at 2.05.50 PM.png75.55 KBwebchick

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes
drumm’s picture

drumm
he/him
Location NY, US
commented

The fieldsets remember the collapsed state for each browser in localStorage.

#collapsed actually didn't change, the field group config is still set to collapsible, not collapsed. The change is new JS added by #2163197: Allow fieldsets to be persistent and save focus when AJAXing. This JS, http://drupalcode.org/project/project_issue.git/blob/refs/heads/7.x-2.x:..., has:

            // If the ID of the fieldset is present in localStorage, it's open.
            if (window.localStorage[id]) {
              $fieldset.removeClass('collapsed');
            }
            // Otherwise, it's closed.
            else {
              $fieldset.addClass('collapsed');
            }

This should also store if the fieldset was closed in localStorage, so the "otherwise section" can do nothing.

drumm’s picture

drumm
he/him
Location NY, US
commented
Project: [Archive] Drupal.org D7 upgrade QA » Project issue tracking
Version: » 7.x-2.x-dev
Component: Code » User interface
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Based on that code, it seems to default to closed the first time you hit this page with empty local storage.
Once you edit the first time, you get angry, uncollapse it, and never hit it again.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Oh, ok, I didn't realize this was all JS stuff. But yeah, that logic needs to be inversed remove the "else" condition like you said.

And then as part of #2159813: Display parts of the issue edit form instead of the comment form on issue pages, we need to add a check for "are we on the front-end or back-end form" when determining the default state.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

I just filed a duplicate of this issue.

I'd like to point out that "never hit it again" only works as long as you stay logged in to d.o. I've had to hit it again every day since this was deployed.

drumm’s picture

drumm
he/him
Location NY, US
commented
Assigned: Unassigned » drumm
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Fixed

http://drupalcode.org/project/project_issue.git/commit/5d8af8b leaves the fieldsets alone if localstorage is not yet defined for the fieldset.

This will be deployed within the next hour.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.