There's no really sensible behavior for pulling values when you're syncing a constant or token, and if you accidentally leave these rows configured as "sync" you get some ugly errors.

CommentFileSizeAuthor
#4 salesforce-pull_fieldtype_validation-2184693-4.patch1.07 KBAaronBauman
#3 salesforce-pull_fieldtype_validation-2184693-3.patch993 bytesAaronBauman
#1 restrict_pull_to_sensible_mapping_types.patch993 bytesgcb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gcb’s picture

gcb
he/him
CreditAttribution: gcb commented
FileSize
restrict_pull_to_sensible_mapping_types.patch993 bytes

Patch attached, needs testing.

gcb’s picture

gcb
he/him
CreditAttribution: gcb commented
Status: Active » Needs review
AaronBauman’s picture

AaronBauman
he/him
CreditAttribution: AaronBauman commented
Category: Feature request » Bug report
FileSize
salesforce-pull_fieldtype_validation-2184693-3.patch993 bytes

I'd probably call this a bug, since it's gonna be throwing notices when calling non-existent functions.

Attaching patch to also add a function_exists() call to this conditional.

AaronBauman’s picture

AaronBauman
he/him
CreditAttribution: AaronBauman commented
FileSize
salesforce-pull_fieldtype_validation-2184693-4.patch1.07 KB

er, updated patch.

mariacha1’s picture

mariacha1 CreditAttribution: mariacha1 at ThinkShout commented
Title: Disable pull for constant & token sync fields » Validation on mappings form submit: Disable pull for constant & token sync fields
Status: Needs review » Needs work
Related issues: +#2612942: errors during salesforce_pull_map_fields()

The issue described here is fixed by https://www.drupal.org/node/2612942 but it would be nice to let people know, when they're saving their mapping form, that constants and tokens can't be pulled. Going to hijack this issue for that purpose. :)