There's no really sensible behavior for pulling values when you're syncing a constant or token, and if you accidentally leave these rows configured as "sync" you get some ugly errors.

CommentFileSizeAuthor
#4 salesforce-pull_fieldtype_validation-2184693-4.patch1.07 KBaaronbauman
#3 salesforce-pull_fieldtype_validation-2184693-3.patch993 bytesaaronbauman
#1 restrict_pull_to_sensible_mapping_types.patch993 bytesgcb

Comments

gcb’s picture

gcb
he/him
Location Portland, OR
commented
StatusFileSize
new restrict_pull_to_sensible_mapping_types.patch993 bytes

Patch attached, needs testing.

gcb’s picture

gcb
he/him
Location Portland, OR
commented
Status: Active » Needs review
aaronbauman’s picture

aaronbauman
he/him
commented
Category: Feature request » Bug report
StatusFileSize
new salesforce-pull_fieldtype_validation-2184693-3.patch993 bytes

I'd probably call this a bug, since it's gonna be throwing notices when calling non-existent functions.

Attaching patch to also add a function_exists() call to this conditional.

aaronbauman’s picture

aaronbauman
he/him
commented
StatusFileSize
new salesforce-pull_fieldtype_validation-2184693-4.patch1.07 KB

er, updated patch.

mariacha1’s picture

mariacha1 commented
Title: Disable pull for constant & token sync fields » Validation on mappings form submit: Disable pull for constant & token sync fields
Status: Needs review » Needs work
Related issues: +#2612942: errors during salesforce_pull_map_fields()

The issue described here is fixed by https://www.drupal.org/node/2612942 but it would be nice to let people know, when they're saving their mapping form, that constants and tokens can't be pulled. Going to hijack this issue for that purpose. :)

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs work » Closed (won't fix)

7.x is no longer supported

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.