We need to rename properties according core standards in views/Plugin/views/filter/ManyToOne.php

Part of meta-issue #2052421: [META] Rename Views properties to core standards

CommentFileSizeAuthor
#5 rename_property_value_form_type-2183423-5.patch1.95 KBinternetdevels
#3 rename_property_value_form_type-2183423-3.patch1.95 KBinternetdevels
#1 rename_property_value_form_type-2183423-1.patch1.94 KBinternetdevels

Comments

internetdevels’s picture

internetdevels commented
Status: Active » Needs review
StatusFileSize
new rename_property_value_form_type-2183423-1.patch1.94 KB
bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Needs review » Needs work

We need to replace "var" with "public/protected".
Please take a look at meta issue.

internetdevels’s picture

internetdevels commented
Status: Needs work » Needs review
StatusFileSize
new rename_property_value_form_type-2183423-3.patch1.95 KB

Change visibility of a property to protected

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Needs review » Needs work

The pedant in me said that we need strong coding standards everywhere.

protected $valueFormType = 'select';
->
protected $valueFormType = 'select';

internetdevels’s picture

internetdevels commented
Status: Needs work » Needs review
StatusFileSize
new rename_property_value_form_type-2183423-5.patch1.95 KB
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Reviewed & tested by the community

Looks good :-)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

This seems like it's internal-only code so probably don't need a change notice.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.