The first proper release of Weblinks for Drupal 7.x is close to being ready. The remaining tasks are:

Issues to be dealt with

  • none

Issues fixed or resolved

This summary will be updated as issues are fixed or testing completed. If anyone would like to help, join in the discussion below.

Comments

jonathan1055’s picture

jonathan1055 commented

To encourage users to test the latest D7 code, can we make an official alpha1 release, to mark it as separate from the latest -dev?

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I would encourage doing that. Many people are reluctant to test dev releases, but have no problem testing alphas.

gstegemann’s picture

gstegemann commented

Good idea.

jonathan1055’s picture

jonathan1055 commented

Shall I see if I can do it? I've not done any releases before.

gstegemann’s picture

gstegemann commented

Yes.

I haven't done it neither. May Nancy can assist you in creating the git branch and you supply/edit the release information.

Gerhard

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

You're not creating a new branch unless you want to begin an 8.x release. You want to create a new tag, from which you can create a release.

At the top of the project page, you will see a "Version control" link. That page summarizes all the usual Git commands. At the top of that page, select the correct branch (7.x-1.x) and make sure the Maintainer box is checked. Then click "Show".

Down at the bottom, you'll see the instructions for a new tag. You'll need something like:

git tag 7.x-1.0-alpha1
git push origin tag 7.x-1.0-alpha1

Once you've done that, you have to go back to the bottom of the project page and click on "Add new release". In the select box, find the correct release and then follow the prompts. Hint: Do not select "Security fixes" are the release will never be created. Most likely you want "Bug fixes" and "New features" (the first release of a new branch is always a new feature).

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Moving #2172019: Undefined variable: extras in weblinks_content_extra_fields() as it is fixed.

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added #2183749: Automated testing and removed the comment from the testing section.

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added #2191355: Undefined property $nid in weblinks_checker_node_presave

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

I've released 7.x-1.0-alpha1. That's my first release on Drupal. In fact, it is my first work using Git, so feeling quite pleased with myself at this moment :-)

gstegemann’s picture

gstegemann commented

Congratulations and many thanks.

Great to have a first release of Web Links.

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes
jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes
jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes
gstegemann’s picture

gstegemann commented
Issue summary: View changes
jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added #2320971: Weblinks Block Module Error In Code
Added #1010674: When hiding a group on the main page, it is also hidden on it weblinks/% page
Moved #2183749: Automated testing

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Removed

  • Review multi language support
  • Translations

from the summary, and added issue #2384111: Translation strings and multi-language support

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added #2386455: Increase last_status db field from 4 to 6 chars
Added #2388053: Related Links block does not work in D7
Added #2384489: Move weblinks when user is deleted
Moved #1010674: When hiding a group on the main page, it is also hidden on it weblinks/% page

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Replaced #2148005: weblinks.weight.inc stores all contributions in sticky 100 and -100 with #2030765: Editing a sticky node sets db field to -100 for non-weblinks nodes. Do not encode weight and remove the weight.inc file as this is the original issue, and the one with the patches.

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added:
#2389923: PHP5 warnings in 7.x - Undefined index, undefined variable, undefined property

Moved to fixed:
#2384489: Move weblinks when user is deleted
#2384111: Translation strings and multi-language support
#2396843: Link options[attributes][class] must be an array

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added
#2406139: Last click time and click count doubled or trebled up in title
#2406433: Popular 'term' content does not filter on the term
#2407353: Conflicting urls for 'All Links' and 'Unclassified Links'

Now fixed
#2030765: Editing a sticky node sets db field to -100 for non-weblinks nodes. Do not encode weight and remove the weight.inc file
#2197719: Undefined offset: 0 in weblinks_get_tree() line 1131 displaying multiple hierarchy terms
#2388053: Related Links block does not work in D7
#2405995: Trying to get property of non-object in weblinks_page()

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Moved the following to the Resolved group:
#314369: Show image in block using D7 core image functionality
#2201081: Interaction with Taxonomy module
#2320971: Weblinks Block Module Error In Code

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Converted the questions to issues:
#2415145: Replacement/rewrite for Taxonomy Image module
#2417699: Replace taxonomy_index with field_data_taxonomy_weblinks table
#2417701: Are any 'links converter' submodules needed for D7?

Added:
#2415693: Weblinks Checker should update node_revision table

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Now fixed:
#460622: Additional automated tests
#2182163: Alexa Pagerank is broken. Fix or drop from D7
#2415693: Weblinks Checker should update node_revision table
#2417701: Are any 'links converter' submodules needed for D7?

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added:
#2425859: Do not allow admins to edit the weblinks vocabulary machine name

Moved to fixed:
#2201861: Separate 'Link Description' and 'View Mode' settings
#2406433: Popular 'term' content does not filter on the term
#2415145: Replacement/rewrite for Taxonomy Image module

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added:
#2429855: Blocks setting "Show description" not working as defined
#2431367: Group descriptions are not shown when 'Make groups collapsible' = No
#2442557: Remove permissions that are now implemented in core node module

Fixed:
#2407353: Conflicting urls for 'All Links' and 'Unclassified Links'

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added #2443235: Add block css using the #attached property which was a split from an earlier issue.

This is the last one I am going to add to this list. We've done a lot of work in using D7 so far and we must have discovered (all of, or nearly all of) the serious issues which would stop a 7.x release. We have to call a halt at some point and complete the open issue list. :-)

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

I thought #2430893: Group settings only shown if the Weblinks Blocks sub-module is enabled. was already in the list but it was not. It should be, so added it. Nine now.

gstegemann’s picture

gstegemann commented

We have to call a halt at some point and complete the open issue list.

I fully agree.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Agreed

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added
#2449127: Remove $node->taxonomy and replace all usages with $node->taxonomy_weblinks (split off from 2417699)

Fixed
#2406139: Last click time and click count doubled or trebled up in title
#2425859: Do not allow admins to edit the weblinks vocabulary machine name
#2429855: Blocks setting "Show description" not working as defined

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Fixed
#2417699: Replace taxonomy_index with field_data_taxonomy_weblinks table
#2430893: Group settings only shown if the Weblinks Blocks sub-module is enabled.
#2431367: Group descriptions are not shown when 'Make groups collapsible' = No
#2452953: 'Maximum links to display' group setting is ignored

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added
#2463501: Link url produces 404 when click-count enabled or clean-urls not enabled

Moved to Fixed
#2389923: PHP5 warnings in 7.x - Undefined index, undefined variable, undefined property
#2442557: Remove permissions that are now implemented in core node module
#2443235: Add block css using the #attached property
#2449127: Remove $node->taxonomy and replace all usages with $node->taxonomy_weblinks

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Fixed:
#2457353: Web Links main Links page information is displayed twice
#2461723: Change usage for 'access weblinks' permission
#2463501: Link url produces 404 when click-count enabled or clean-urls not enabled

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added #2468615: Unknown column 'taxonomy_weblinks_tid' when using non-weblinks taxonomy

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Added:
#2482165: Error message "Invalid group requested" on non-weblinks vocabulary
#2485709: Disable selection of vocabularies without fields

Fixed:
#2468615: Unknown column 'taxonomy_weblinks_tid' when using non-weblinks taxonomy
#2481521: Expand the information returned by _weblinks_vocabulary_field_info()

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Fixed
#2425859: Do not allow admins to edit the weblinks vocabulary machine name
#2482165: Error message "Invalid group requested" on non-weblinks vocabulary
#2485709: Disable selection of vocabularies without fields

jonathan1055’s picture

jonathan1055 commented
Status: Active » Fixed

Great to get 7.x-1.0 released. I used the above list on the release page 7.x release https://www.drupal.org/node/2487542 - useful to have all these issues collected here.

gstegemann’s picture

gstegemann commented

Yes, a big step forward. Thanks a lot.

I used the above list on the release page 7.x release

And the Web Links homepage needs an update as well.

jonathan1055’s picture

jonathan1055 commented

I've updated our project homepage.

gstegemann’s picture

gstegemann commented

And I've updated the 'Comparison of Links Page modules' page.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Well done, guys. Thank you very much.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.