Updated: Comment #N

Problem/Motivation

The cancel link on admin job overview leads to an inexisting page (cancel) that finally shows the job (with a destination argument).
Every button pressed then leads back to the origin.
That's why, hitting there the real abort button also doesn't work.

Proposed resolution

Just fix label cancel to abort.
And also fix the target cancel to abort.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#5 2182099-cancel_link-3.interdiff.txt1.49 KBblueminds
#5 2182099-cancel_link-3.patch2.34 KBblueminds
#3 2182099-cancel_link-2.patch1.39 KBblueminds
#1 2182099-cancel_link-1.patch865 bytesblueminds

Comments

blueminds’s picture

blueminds commented
Status: Active » Needs review
StatusFileSize
new 2182099-cancel_link-1.patch865 bytes

please see the patch

Status: Needs review » Needs work

The last submitted patch, 1: 2182099-cancel_link-1.patch, failed testing.

blueminds’s picture

blueminds commented
Status: Needs work » Needs review
StatusFileSize
new 2182099-cancel_link-2.patch1.39 KB

yup, missed that one

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Generally yes.
But note that there's no test if this link goes to the right confirmation page. That was the origin of the bug. Thus we should test it.

blueminds’s picture

blueminds commented
Status: Needs work » Needs review
StatusFileSize
new 2182099-cancel_link-3.patch2.34 KB
new 2182099-cancel_link-3.interdiff.txt1.49 KB

yup

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/sources/node/ui/tmgmt_node_ui.test
@@ -96,17 +96,22 @@ class TMGMTNodeSourceUITestCase extends TMGMTEntityTestCaseUtility {
-
     $this->drupalPost(NULL, array(), t('Submit to translator'));
+    // After submit the redirect goes back to the job overview.
+    $this->assertUrl('admin/tmgmt');

Why is this necessary now? It should default to go back to the overview?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

I was confused, ignore that. Committed and pushed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.