There is an extra semicolon (two semicolons together at the end of the line) in line 4224 of core/includes/common.inc

Comments

malionek’s picture

Assigned: malionek » Unassigned
Status: Active » Needs review
StatusFileSize
new648 bytes

Uploaded a patch to remove the extra semicolon.

moshe weitzman’s picture

Status: Needs review » Reviewed & tested by the community

Both parts of the semicolon are properly removed. Nice.

scor’s picture

Title: Extra semicolon in common.inc » Extra semicolon & wrong spacing between dot and concatenated parts in common.inc
Status: Reviewed & tested by the community » Needs work
+++ b/core/includes/common.inc
@@ -4221,7 +4221,7 @@ function drupal_render_cache_generate_placeholder($callback, array $context, $to
-  return '<drupal:render-cache-placeholder callback="' . $callback .  '" context="' . $context_attribute . '" token="'. $token . '" />';;
+  return '<drupal:render-cache-placeholder callback="' . $callback .␣␣'" context="' . $context_attribute . '" token="'. $token . '" />';
 }

There are a couple of space that I've marked with "␣" right after the second callback (only one is necessary), are we're also missing a space in between the first token and its following ".".

malionek’s picture

Assigned: Unassigned » malionek
malionek’s picture

Assigned: malionek » Unassigned
Status: Needs work » Needs review
StatusFileSize
new731 bytes

Corrected spacing and and removed extra semicolon in common.inc and submitted a new patch.

Anonymous’s picture

Status: Needs review » Needs work

The patch fixes all issues that were mentioned above, but it also indents the curly bracket on line 4134.

malionek’s picture

Assigned: Unassigned » malionek
malionek’s picture

Assigned: malionek » Unassigned
Status: Needs work » Needs review
StatusFileSize
new648 bytes

Fixed the final curly brace positioning problem in common.inc line 4234 along with the previous edits with spacing and the extra semicolon and created a new patch.

malionek’s picture

The curly bracket fix was on line 4134, not line 4234 as was indicated in the last comment.

scor’s picture

Status: Needs review » Reviewed & tested by the community

Patch whitespaces look good now, back to RTBC. Thanks @malionek for following up after the Boston code sprint!

kay_v’s picture

Nice work getting a handle on the process for core contributions, @malionek --the semicolon is just a start!

That said, out of curiosity I grepped for other occurrences of double semicolons. Seems there are more of the same type of fix needing attention. Care to take on others?

If so, in Terminal on your Mac, navigate to your d8 docroot again and at the $ prompt enter the following (including the period):
grep -r ';;' .
You'll get a list of a few files that match that pattern.

You'll want to create a new issue for these other fixes, since they are unrelated to this one (I bet I'm breaking that protocol by bringing these other semicolons up here, fwiw).

Ignore the binary files (e.g. Binary file ./core/modules/views_ui/images/loading.gif ...) and ones that have any of the following in the path:

  • .git (e.g. ./.git/hooks/update.sample: ;;)
  • vendor (e.g. ./core/assets/vendor/modernizr/modernizr.js:});;)

Feel free to ping me on #drupal-ladder if you'd like more info or get stuck. Naturally, core mentoring hours (see drupalmentoring.org) are also a great way to get insights/help on core contribution.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed f17c8b3 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.