Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
25 Jan 2014 at 17:13 UTC
Updated:
29 Jul 2014 at 23:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
malionek commentedUploaded a patch to remove the extra semicolon.
Comment #2
moshe weitzman commentedBoth parts of the semicolon are properly removed. Nice.
Comment #3
scor commentedThere are a couple of space that I've marked with "␣" right after the second callback (only one is necessary), are we're also missing a space in between the first token and its following ".".
Comment #4
malionek commentedComment #5
malionek commentedCorrected spacing and and removed extra semicolon in common.inc and submitted a new patch.
Comment #6
Anonymous (not verified) commentedThe patch fixes all issues that were mentioned above, but it also indents the curly bracket on line 4134.
Comment #7
malionek commentedComment #8
malionek commentedFixed the final curly brace positioning problem in common.inc line 4234 along with the previous edits with spacing and the extra semicolon and created a new patch.
Comment #9
malionek commentedThe curly bracket fix was on line 4134, not line 4234 as was indicated in the last comment.
Comment #10
scor commentedPatch whitespaces look good now, back to RTBC. Thanks @malionek for following up after the Boston code sprint!
Comment #11
kay_v commentedNice work getting a handle on the process for core contributions, @malionek --the semicolon is just a start!
That said, out of curiosity I grepped for other occurrences of double semicolons. Seems there are more of the same type of fix needing attention. Care to take on others?
If so, in Terminal on your Mac, navigate to your d8 docroot again and at the $ prompt enter the following (including the period):
grep -r ';;' .You'll get a list of a few files that match that pattern.
You'll want to create a new issue for these other fixes, since they are unrelated to this one (I bet I'm breaking that protocol by bringing these other semicolons up here, fwiw).
Ignore the binary files (e.g. Binary file ./core/modules/views_ui/images/loading.gif ...) and ones that have any of the following in the path:
Feel free to ping me on #drupal-ladder if you'd like more info or get stuck. Naturally, core mentoring hours (see drupalmentoring.org) are also a great way to get insights/help on core contribution.
Comment #12
alexpottCommitted f17c8b3 and pushed to 8.x. Thanks!