Right now there is no context to the flag in question (aside from some various data injected via $info). Will attach a patch shortly.

CommentFileSizeAuthor
#6 2177859-flag_flag_javascript_info_alter-6.patch1.87 KBmarkhalliwell
#4 2177859-flag_flag_javascript_info_alter-4.patch1.87 KBmarkhalliwell
#1 2177859-flag-flag_javascript_info_alter-1.patch845 bytesmarkhalliwell

Comments

markhalliwell’s picture

markhalliwell
Primary language English
commented
Title: Include $flag for reference in hook_flag_javascript_info() » Include $flag for reference in hook_flag_javascript_info_alter()
Status: Active » Needs review
StatusFileSize
new 2177859-flag-flag_javascript_info_alter-1.patch845 bytes
fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

It is always nice to pass contextual data as further parameters to drupal_alter. Works nicely here.

joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Needs work

Looks good, but a change in function behaviour needs a corresponding change in documentation!

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 2177859-flag_flag_javascript_info_alter-4.patch1.87 KB

Ironically, the API documentation itself was already inaccurate. Here's an updated patch.

Status: Needs review » Needs work

The last submitted patch, 4: 2177859-flag_flag_javascript_info_alter-4.patch, failed testing.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 2177859-flag_flag_javascript_info_alter-6.patch1.87 KB

Sigh, edited it an old IDE (which doesn't pick that stuff up). Here's the correct patch.

joachim’s picture

joachim commented
Status: Needs review » Fixed

Committed. Thanks for the fixes to the docs!

git commit -m "Issue #2177859 by Mark Carver: Added \$flag parameter to hook_flag_javascript_info_alter()." --author="markcarver "

joachim’s picture

joachim commented

Change record: https://drupal.org/node/2181977

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.