Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

CommentFileSizeAuthor
#5 2177651-theme-d_r-errors-5.patch617 bytesjoelpittet
#2 errors-2.png19.04 KBjessebeach
#2 testing-patch.txt1.5 KBjessebeach
#1 drupal-replace_theme_function_with_drupal_render-2177651-1.patch952 bytesinternetdevels

Comments

internetdevels’s picture

internetdevels commented
Status: Active » Needs review
StatusFileSize
new drupal-replace_theme_function_with_drupal_render-2177651-1.patch952 bytes

Patch attached.

jessebeach’s picture

jessebeach commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new testing-patch.txt1.5 KB
new errors-2.png19.04 KB

This patch can be tested by applying the provided testing patch and then navigating to /core/update.php. You will see the error message produced by the renderable in errors.inc.

catch’s picture

catch
he/him
Primary language English
commented

1: drupal-replace_theme_function_with_drupal_render-2177651-1.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: drupal-replace_theme_function_with_drupal_render-2177651-1.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review
StatusFileSize
new 2177651-theme-d_r-errors-5.patch617 bytes

Re-rolled

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.