Replace theme() with drupal_render() in batch.inc [#2177643]

Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

Comment	File	Size	Author
#5	batching-2.png	16.9 KB	jessebeach
#5	drupal_render-batch-2177643-3-proof.txt	1.06 KB	jessebeach
#3	drupal-replace_theme_function_with_drupal_render-2177643-3.patch	1010 bytes	internetdevels
#1	drupal-replace_theme_function_with_drupal_render-2177643-1.patch	1010 bytes	internetdevels

Comments

Comment #1

internetdevels commented 21 January 2014 at 15:21

Status:

Active

» Needs review

Status	File	Size
new	drupal-replace_theme_function_with_drupal_render-2177643-1.patch	1010 bytes

Patch attached.

Comment #2

21 January 2014 at 15:22

Status:

Needs review

» Needs work

The last submitted patch, 1: drupal-replace_theme_function_with_drupal_render-2177643-1.patch, failed testing.

Comment #3

internetdevels commented 21 January 2014 at 15:51

Status:

Needs work

» Needs review

Status	File	Size
new	drupal-replace_theme_function_with_drupal_render-2177643-3.patch	1010 bytes

1 file was hidden/shown/deleted

Status	File	Size
hidden	drupal-replace_theme_function_with_drupal_render-2177643-1.patch	1010 bytes

Incorrect file has been sent above. This one should be good.

Comment #4

jessebeach commented 21 January 2014 at 16:44

Looks good. Let's hope the bot likes it.

Comment #5

jessebeach commented 23 January 2014 at 03:20

Status:

Needs review

» Reviewed & tested by the community

Status	File	Size
new	drupal_render-batch-2177643-3-proof.txt	1.06 KB
new	batching-2.png	16.9 KB

To test this patch, apply the supplied testing patch, then enable the batch_test module. Navigate to /batch-test/multistep and run a multi-step batch.

You should then see the following page.