If I have a submenu on a page, it shows correctly with the correct with the siblings of the current top level menu item. Then I edit the page with IPE and click save. Then it shows a submenu from another top level menu item. Reload the page, and the correct submenu is shown again. It is a wierd kink, but rather confusing for the editors :)

CommentFileSizeAuthor
#4 panopoly_magic-submenu-preview-2177417-4.patch924 bytesdsnopek
#4 panopoly_core-submenu-preview-2177417-4.patch934 bytesdsnopek

Comments

caschbre’s picture

caschbre commented

I've noticed similar behavior when using the IPE. I don't think this is Panopoly specific, rather an issue with panels and ajax. I've had behavior where other panes don't disappear or show different data after saving in the IPE. A page refresh fixes it.

lsolesen’s picture

lsolesen commented

However, with the submenu this is very consistent and testable, so maybe it can help solve the main issue? #2149171: Write Behat tests for Panopoly "submenu" widget

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Title: Submenu widget » Widget output when editing with IPE can be different than when viewing the page normally (easily reproducable with "Submenu" widget)

Updating title to reflect the fact that this issue affects more widgets than just the "Submenu" widget.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
Related issues: +#2897658: Menu blocks disappear when editing/saving in the Panels IPE, +#2897965: Wizard sets destination incorrectly
StatusFileSize
new panopoly_core-submenu-preview-2177417-4.patch934 bytes
new panopoly_magic-submenu-preview-2177417-4.patch924 bytes

Here's patches for Panels and CTools that fix the IPE output after editing a Submenu pane and saving the whole display:

And I've attached a patch to add those patches, and a patch to panopoly_magic that fixes the preview in the same ways as in the Panels IPE issue.

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/258265147

cboyden’s picture

cboyden commented

This is looking great for submenu widgets and other menu blocks. Are there other types of widgets we should test with?

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Thanks for testing! Breadcrumbs are probably also fixed by this, but that's not a super common widget to use in the IPE. :-)

cboyden’s picture

cboyden commented
Status: Needs review » Reviewed & tested by the community

We've been using this setup for a bit and it's working as expected.

  • dsnopek committed 4817919 on 7.x-1.x 
    Update Panopoly Core and Magic for Issue #2177417 by dsnopek: Widget...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.