webform_node_update() updates webform nid from $node object as it does for components when component is updated but this does not happen if component is new to be inserted or not existing and to be deleted.

This is mainly issue when webform node is getting updated from code.

CommentFileSizeAuthor
#1 webform_reassign_component_nid-2177403-1.patch865 bytesmikran

Comments

mikran’s picture

mikran commented
Status: Active » Needs review
StatusFileSize
new webform_reassign_component_nid-2177403-1.patch865 bytes

and a patch

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Thanks, I could see how this might occur. Committed to the 7.x-4.x branch. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Version: 7.x-4.x-dev » 8.x-4.x-dev
Assigned: Unassigned » fenstrat
Status: Closed (fixed) » Patch (to be ported)

Needs porting to 8.x-4.x.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Version: 8.x-4.x-dev » 7.x-4.x-dev
Assigned: fenstrat » Unassigned
Status: Patch (to be ported) » Fixed

Committed and pushed to 8.x-4.x. Thanks!

  • Commit 31e3186 on 8.x-4.x authored by mikran, committed by fenstrat: 
    Issue #2177403 by mikran: Hook_node_update() implementation doesn't...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.