Closed (fixed)
Project:
Commerce DPS
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
18 Jan 2014 at 21:20 UTC
Updated:
30 Mar 2015 at 03:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
xurizaemonComment #2
xurizaemonComment #3
millionleaves commentedI get a white screen when I try to configure the rule. Error log tells that this function is undefined: commerce_dps_currencies when called from commerce_dps_pxpost.module.
Tried changing the function name to commerce_dps_pxpay_currencies but that didn't help. I've got the multicurrency patch from 1927650, in case that's relevant.
Comment #4
xurizaemonNeeds https://www.drupal.org/files/issues/commerce_dps-2266829-shared_dps-4.patch from #2266829: Split shared DPS functionality to commerce_dps module also, sorry bout that!
(and maybe a manual cache clear)
Comment #5
millionleaves commentedThanks. That has resolved the problem i was having.
However, now I have trouble when I get to checkout and enter the credit card details. I've had a couple of test orders go through OK, but the rest of the time it either goes to a blank screen or I get the error "We received the following error processing your card. Please enter your information again or try a different card."
Note that when I use a CC of anything other than 4111111111111111, I get a message stating "You have entered an invalid credit card number." so I don't believe the issues above relate to the credit card details.
I have tried this when logged in and as an anonymous user. I have also tried it with the multicurrency module enabled and disabled. Same randomness either way.
I have the module writing to the logs so can provide further detail based on those entries if needed.
Comment #6
millionleaves commentedUpdate - should have looked a little harder before posting. Found this in the server logs:
PHP Fatal error: Call to undefined function commerce_cardonfile_load_multiple_by_uid() in var/www/[SITENAME]/sites/all/modules/commerce_dps/commerce_dps_pxpost.module on line 556
The function is also called in line 600.
Comment #7
xurizaemonConfession time: I worked on a bunch of issues (the two mentioned above included), and the WIP is sitting over in https://github.com/xurizaemon/commerce_dps ... I haven't had feedback from that client yet (chased them up now) and turning the changes over on Github back into "nice clean" Drupal.org issues just hasn't been a priority.
So - you can test all those changes together by grabbing the code from Github, and maybe I'll just open a meta-issue here for all of the above. The relevant commits are all labelled over on Github.
If people weren't apparently running 7.x-1.x-dev as much as 7.x-1.0 I would just push the commits and wait for feedback ... you're probably several of those sites David? :D
Comment #8
xurizaemonLooks like a legit bug though, shouldn't be calling that unless we've checked you're using Commerce Card on File (part of #2397663: Token payment support ("card on file")).
Comment #9
millionleaves commentedI will confess that I have various sites running -dev, mainly to take advantage of the newer features you've added in recent months.
But I have several new sites in development (including the one where this issue is occurring) so will switch to the code from Github for those sites. Have just tried it on one site and all seems to be working (especially now I have Commerce Card on File enabled) but will need to test some additional use cases.
As always, appreciate your work on this module.
Comment #11
xurizaemon