Closed (fixed)
Project:
Translation template extractor
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Jan 2014 at 18:11 UTC
Updated:
22 Sep 2020 at 12:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pbuyle commentedThe patch in potx-drush_language-2175955-2.patch implements the suggested solution. It has been build and tested on the 7.x-1.x branch (after copying the potx.drush.inc file from the 6.x-3.x branch, see [#720986#42]). The only changes are on the potx.drush.inc file, so the patch should safely apply to the 6.x-3.x branch.
Comment #2
pbuyle commentedComment #3
FreekVR commentedThanks, this works! Note that the patch also applies fine on the 7.x-3.x branch.
Comment #4
PascalAnimateur commentedI can confirm the patch works with potx 7.x-3.x-dev also. Should it be committed there too ?
Comment #5
drzraf commentedpotx single --translations --language frBecause this should be
--language=fr, maybe code could catch this.The only confusing thing is that filename is still
general.potrather than, eg,project.fr.po(could be link to issue #2730189: drush extract output directory so that
singlecan be set to export to stdout so one can redirect in whatever file he wants)Comment #6
drdam commentedpatch #2 OK for me
Subscribe the #5 : I think its a really good idea
Comment #7
dmsmidtAnother +1 if we fix naming files in the follow up.
Comment #8
gábor hojtsySent it to test with 8.1 assuming it applies. It still has the same drush.inc file.
Comment #9
gábor hojtsyWould be great to have a 8.x patch as well, so we can commit to both branches at once. I would not like to commit features into the 7.x branch only at this point. (I know I was slacking off maintaining the module, so that is my fault).
Comment #10
gábor hojtsyRerolled for 8.x
Comment #11
gábor hojtsyDuh, that was rolled against 7.x still. Rerolling against 8.x for real now.
Comment #12
gábor hojtsyComment #16
gábor hojtsyThanks all. Committed to 8.x including a followup commit to fix the missing language_list() :D Also committed to 7-3.x.
Comment #17
gábor hojtsyRealized this was not ported to the Drush 9/10 integration API. Opened #3169697: New language and translations options were not added to Drush 9/10 integration.