This has really been driving me nuts. So itch, meet scratch.

In order to call debug(array()) I need to type debug(array(), '', TRUE). The TRUE indicates that print_r should be used instead of var_export. Fair enough, but that empty string is necessary in order to get to the third argument, which is FALSE by default.

So I propose that if the second argument is a Boolean, just deal with it and use print_r without a label.

CommentFileSizeAuthor
#9 make_debug_use-2174507-9.patch1.34 KBalansaviolobo
#7 make_debug_use-2174507-7.patch1.34 KBalansaviolobo
#6 debug-2174507-6.patch1.4 KBtim.plunkett
#4 debug-without-a-label-2174507-4.patch1.33 KBjessebeach
debug-without-a-label.patch1.04 KBjessebeach

Comments

jessebeach’s picture

jessebeach commented
Issue summary: View changes
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented 
+++ b/core/includes/common.inc
@@ -5033,6 +5033,13 @@ function _drupal_flush_css_js() {
 function debug($data, $label = NULL, $print_r = FALSE) {

Why not just switch the param orders? I've never used the label, I use the print_r flag a lot. But i think this is almost more confusing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I don't think we should mis-use an argument for something else.

I use the label quite a lot, helps when to identify things when you have a lot of debug statements.

jessebeach’s picture

jessebeach commented
StatusFileSize
new debug-without-a-label-2174507-4.patch1.33 KB

Let's set $print_r to be true by default then.

Status: Needs review » Needs work

The last submitted patch, 4: debug-without-a-label-2174507-4.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Allow a user to call debug() on an array with print_r without a label » Make debug() use print_r() by default
Status: Needs work » Needs review
Issue tags: -OMGWTFBBQ +Drupal wtf
StatusFileSize
new debug-2174507-6.patch1.4 KB

Fine by me.

alansaviolobo’s picture

alansaviolobo commented
StatusFileSize
new make_debug_use-2174507-7.patch1.34 KB

reroll

Status: Needs review » Needs work

The last submitted patch, 7: make_debug_use-2174507-7.patch, failed testing.

alansaviolobo’s picture

alansaviolobo commented
Status: Needs work » Needs review
StatusFileSize
new make_debug_use-2174507-9.patch1.34 KB

ended up exporting a reversed patch.

Status: Needs review » Needs work

The last submitted patch, 9: make_debug_use-2174507-9.patch, failed testing.

Status: Needs work » Needs review

alansaviolobo queued 9: make_debug_use-2174507-9.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 9: make_debug_use-2174507-9.patch, failed testing.

Status: Needs work » Needs review

alansaviolobo queued 9: make_debug_use-2174507-9.patch for re-testing.

marvil07’s picture

marvil07 commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +DX

Reroll seems fine and still applies.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: -Drupal wtf, -DX +DX (Developer Experience), +DrupalWTF
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committing under the reduced fragility provision of the beta evaluation. Committed 5d36a99 and pushed to 8.0.x. Thanks!

  • alexpott committed 5d36a99 on 8.0.x 
    Issue #2174507 by jessebeach, alansaviolobo, tim.plunkett: Make debug()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.