Problem/Motivation

Currently moopapi_wrap(), which is only called by moopapi_init(), uses variable_set() to store, as far as I can tell, temporary runtime information.
This is a bad idea because variable_set() triggers a write to the DB as well as cache_clear_all('variables', 'cache_bootstrap');.
This has an unnecessary negative performance impact.

Proposed resolution

Simply use the global $conf array to temporarily adjust / overwrite the stored configuration.

Remaining tasks

Reviews needed.

User interface changes

None

API changes

None

Comments

PatchRanger’s picture

Status: Needs review » Patch (to be ported)

Thanks a lot, sounds reasonable, sorry for delay.
Here is the commit to 7.x-2.x: http://drupalcode.org/project/moopapi.git/commit/dd69050 .
Am going to commit to 7.x-1.x.

PatchRanger’s picture

Version: 7.x-1.x-dev » 6.x-2.x-dev
PatchRanger’s picture

Version: 6.x-2.x-dev » 6.x-1.x-dev
PatchRanger’s picture

Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.