After 3 years and contributions from dozens of developers, #1033202: [Meta] Generic entity processor is finally fixed in the dev snapshot of the Feeds module. This is a little different from the patch we've been using. The UI is from this patch where the entity processor is marked as EXPERIMENTAL...
https://drupal.org/comment/7680135#comment-7680135
This official branch needs more testing and will require resaving existing Feed Importer when it's committed. Once the community feels there's been enough testing, remove the patch from this line http://drupalcode.org/project/cm_starterkit_easy.git/blob/refs/heads/7.x...
This testing needs to be done ASAP as the patch will NOT apply the current dev branch causing the drush make process to fail.
| Comment | File | Size | Author |
|---|
Comments
Comment #1
kreynen commentedComment #2
kreynen commentedUpdating this is now critical since 7.26 of Drupal core was pushed today which has a security update https://drupal.org/SA-CORE-2014-001. We can't package the security updates to any of the community media starter kits until the Feeds issue is resolved. Because the patch is applied to the 2.x dev snapshot and a variation of that patch has been applied, the drush make will fail.
Comment #3
kreynen commentedComment #4
jdcreativity commentedI just tried to activate the dev branch and received this message:
Will keep trying.
Comment #5
jdcreativity commentedNeeded to install Feeds_media_internet_files
in order to enable VOD Feeds module.
Following which I got this message:
Comment #6
jdcreativity commentedWish I was more helpful - but the version of Feeds appears to be:
Feeds 7.x-2.0-alpha8+13-dev
Comment #7
kreynen commented@avguy added #2174563: Add Feeds: Media Internet Files to easy yesterday, but we can't package a new distribution build until we are sure most sites can use the dev snapshot version of Feeds for Airings and VOD... so feeds_media_internet_files needs to be manually added to sites/all/modules for now. I made an update to feeds_media_internet_files to fix an issue with the Cloudcast file naming http://drupalcode.org/project/feeds_media_internet_files.git/commit/91665c0
The default import included w/ cm_vod_feed was updated http://drupalcode.org/project/cm_vod_feed.git/blobdiff/8f77ad5872d8f5c81...
But that Feature export only works with new installs. Existing imports need to be manually updated similar to how the OG settings had to be reconfigured after the OG2 update... and similarly the OG/Project documentation was never updated to explain how to do that. Several people said they'd help update the documentation, but only after I updated helped update their site.
The biggest issue w/ Feed driven VOD libraries right now is the documentation for https://drupal.org/node/1556246 hasn't been updated to show how to update Feed Importer. I wrote this code back at the ACM in SF and created a screencast, but that's where the progress stopped.
cm_vod_feed may need to be updated again to remove eliminate the "Missing Feeds plugin FeedsEntityProcessorFile", but all existing Entity feeds also need to be updated. That's what we need to be testing and documenting.
Comment #8
avguy commentedI tested this for importing VODs from Telvue. With the addition of Feeds: Media Internet Files it works as expected.
Comment #9
avguy commentedComment #10
kreynen commentedMoving this back to "Needs work". I want to stop pushing updates that we know will cause problems without documentation the average site admin can follow to fix the issue and at least one station staffer familiar enough with the issues to point people to that documentation.
While it's possible to make the new code work, there is no documentation in https://drupal.org/node/1556246 or anywhere other than the screencast about mapping Title -> field_title. Pushing this change will likely break existing feed importers. When this happened with the OG1 -> OG2 upgrade, all progress stopped.
We need clear, step by step instructions that site admins can follow to resave or remap their importers. Without that, pushing this fix just creates more work for me manually updating every site.
We've pushed Feeds down to Easy so stations could build VOD libraries like http://okv.se/play. We are getting close to making this as easy as Miro... spin up a site, add the URL of a Cloudcast, YouTube, or Vimeo RSS feed, and the result is something that looks like OKV's library.
It's taken 3 years to get this functionality into the Feeds module along with all the other code that makes it possible from mapping the additional MediaRSS elements with https://drupal.org/project/feeds_mediarss, handle mapping the URL and Title with https://drupal.org/project/feeds_media_internet_files, and actually displaying the video with https://drupal.org/project/media_cloudcast or any of the other media_[provider] modules.
I want people using Feeds to pull in VODs and Airings to provide feedback that they understand how this update is going to impact their site and that they are ready for it (even want it) vs. pushing an update that just results in more issues.
Comment #11
jdcreativity commentedI think my feed is broken. With help from @kreynen, I have gotten the EXPERIMENTAL Feeds - Dev version installed on my Dev site on Pantheon. So, essentially, I am using the new module with an existing feed.
What I am seeing that I do not have under the Structure > Feeds importers > Cloudcast Feed > Mapping ---> I have No targets to map to. I'm sure there could be a number of reasons why - but all targets are missing.
I checked under Structure > File Types > Videos > Manage Fields and all the fields that I really want including field_title are present.
Need to keep digging.
Comment #12
kreynen commentedThe File Type setting has to be reset after the upgrade. Fields are added to file entities by type similar to how fields are added to content types. You have to set the Bundle to the Video file type before fields added to that type are available to map.
We need instructions about updating Feed Importer mappings added to https://drupal.org/node/1556246 or somewhere else in the documentation you feel makes sense.
EVERYONE USING FEEDS W/ AN ENTITY IS GOING TO HAVE TO RE-SAVE THEIR FEED IMPORTERS AFTER THE UPDATE IS APPLIED!
In previous updates to the distribution, site admins apply the updates, then open issues about what breaks spending developer time to fix it. In this case we are aware of what the update will break and the steps to fix the Feed Importer can be easily followed.
So the next steps are:
For the sites that have been testing the Feeds update, they will need to remove the dev snapshot of Feeds from sites/all.
Comment #13
emilyf commentedI don't personally run an easy starterkit but wanted to test out this patch as well. For the record, did the following:
- Fresh install of Easy Starterkit + most recent cm_project, media_cloudcast, og 7-2.4, feeds_media_internet_files, and media_feeds
- Added a media field to show content type (realize some people do it other way around, but my preference is to add the media asset to the show)
- Set up a feed importer using the current feeds module included in starterkit to map to entity node, using media cloudcast parser, and link field mapped to my show vod field with media_internet
- Imported a few cloudcast shows. All is working and cloudcast player displaying.
Next installed the latest dev release of feeds with the new patch included. Now see the new "EXPERIMENTAL" feed area, clicked "save" under my mappings. Did another import with new shows added to my feed, all comes in and displays properly.
So based on my testing, all appears to be working well and correctly. I believe I may be using a different way of mapping than some of you guys, but I wanted to provide my feedback that this new patch is definitely working by mapping to a file entity reference on the show content type using media_internet as the mapper. @jdcreativity let me know if you want more feedback, or if perhaps we want to post a couple of screencasts showing the different ways this can be mapped successfully let me know. Hope this is helpful.
Comment #14
kreynen commentedUsing media_feeds to map to a file field doesn't test the entity processor. feeds_media_internet_files returns nothing if the file object lacks the URL that is added by Feeds, but it's good to know it doesn't break the old media_feeds approach.
Comment #15
jdcreativity commentedI was hoping I'd feel comfortable enough to document this process. So, I thought it would be a good idea to create a VOD Feed from Vimeo using the new branch. I received the following error:
Cannot acquire lock for source "name of feed here"/ 0.when trying to import.Comment #16
avguy commented@ jdcreativity, I had that issue yesterday while preparing the screencast. Check and make sure that you enabled the Media provider module, which in your case would be Media:Vimeo.
Comment #17
kreynen commentedI created #2113223: Show warning if no media_[provider] modules are enabled when I made the mistake of trying to import media without the right media_[provider] module enabled.
Adding that warning would only take 30-40 minutes. Anyone want to fund that development so no one else makes this mistake?
Comment #18
avguy commentedI just posted a new screencast demonstrating how to manually configure a feed importer and listing all the modules necessary for making this work in a starterkit. you can find it here:https://drupal.org/node/2049549
Comment #19
kreynen commentedhttp://drupalcode.org/project/cm_starterkit_easy.git/commit/32f3b57