I'm using some CKEditor input filters that have no type specified, throwing the typical:

The filter "xxxxxxxxx" has no type specified! This is required for the Edit module. Please consult Edit module's README.

The filters are:
"filter_footnotes" (https://drupal.org/project/footnotes)
"biblio_filter_reference" (https://drupal.org/project/biblio)
"ckeditor_link_filter" (see also #1882646: Filter ckeditor_link_filter has no type specified! )
"smart_paging_filter" (https://drupal.org/project/smart_paging)
"smart_paging_filter_autop" (https://drupal.org/project/smart_paging)

Is it possible to upgrade filter.inc to include these new contributed filters (as done in #2166957: Add HTML Purifier Support)? Or should I ask to every project mantainer to insert type definition? (as other are doing: see #2147433: Specify Type for Edit Compatibility, #1998164: Update oembed filter definitions to contain "type", #1882646: Filter ckeditor_link_filter has no type specified! )
thanks

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

I'll add them in Edit module. Thanks for reporting!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: CKEditor filter type support » Specify filter type for biblio_filter_reference, biblio_filter_inline_reference, ckeditor_link_filter, filter_footnotes, node_embed, oembed, smart_paging_filter and smart_paging_filter_autop
Assigned: Unassigned » wim leers
Status: Active » Fixed
Issue tags: +Spark

I also specified the filter types for all those other missing filter types you linked to as well :)

http://drupalcode.org/project/edit.git/commit/f835e34

andrebonfanti’s picture

andrebonfanti commented

Thanks! :)

I'm having this message in the admin/reports/status page:

Fatal error: Call to undefined function _navbar_libraries_get_preferred_variant_name() in /homez.547/[xxxxxxxxx]/www/sites/all/modules/edit/edit.install on line 27

The status page remains blank, with this message.

I see in the code that there is a "todo" for this function. But I'm not a programmer, so I do not know how to solve it.
Do I need "Mobile Friendly Navigation Toolbar" module and/or its libraries (backbone, modernizr, etc.)?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#3: good catch, but that's in fact a completely unrelated problem. It's because of #2169507: Improve Libraries API integration, which copy/pasted code from the navbar module, but I unfortunately forgot to rename one piece of code: the part you cited. It's just been fixed!

P.S.: next time, please open an issue, because this is unrelated to the original issue. Also: most maintainers aren't notified of new comments on issues marked as "fixed", so they usually will never even see new comments!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

artofakt’s picture

artofakt commented

Could you please also add the collapse text filter?
Thanks for all of your great contributes and support.