Undefined variable: extras in weblinks_content_extra_fields()

Thanks.

I will take care about it.

Gerhard

Applied and commited.

I would mention two things regarding this this issue:

1. D6 version: @Nancy: shall we release a new version now?
2. D7 version: the CCK integration needs more changes, i.e. changing hook_content_extra_fields to hook_field_extra_fields. I've prepared the necessary changes and will commit them soon. First I want to do more testing.

How many changes are in 6.x; what are their severity; is the release well tested?

Here is a list of all changes appled to 6.x-dev since November 2013:

[Sun, 19 Jan 2014 16:05:41 +0000] Issue #2172019 by jonathan1055: Undefined variable: extras in weblinks_content_extra_fields().

[Fri, 22 Nov 2013 22:56:18 +0000] Issue #2089245 by jonathan1055: Weblinks_cron() does nothing and can be deleted.

[Fri, 22 Nov 2013 16:26:01 +0000] by GStegemann: contribs/weblinks_blocks: several PHP notices fixed.

[Wed, 20 Nov 2013 22:19:19 +0000] by GStegemann: Patch for untranslated string backported from D7 version.

[Fri, 15 Nov 2013 22:48:53 +0000] Issue #2030337 by GStegemann: Sub Module Links Package Converter re-added.

[Fri, 15 Nov 2013 22:38:23 +0000] Issue #1964312 by GStegemann: Pageranks are not updated by cron. Var. pralexa_cron_last initialized.

[Fri, 15 Nov 2013 22:20:36 +0000] Issue #2089201 by jonathan1055: Undefined index warnings in _weblinks_checker_fix_url().

[Fri, 15 Nov 2013 21:55:12 +0000] Issue #1964324 by GStegemann: Google pagerank queries return error 403. URL fixed.

[Fri, 15 Nov 2013 13:43:01 +0000] Issue #2089231 by jonathan1055: Undefined property: stdClass::/ in weblinks_get_tree().

[Thu, 14 Nov 2013 23:23:56 +0000] Issue #2089443 by jonathan1055: Undefined index: #value in weblinks_checker_form_alter().

[Thu, 14 Nov 2013 22:40:17 +0000] Issue #2089235 by jonathan1055: Undefined variable: min in weblinks_checker_settings() fixed.

[Thu, 14 Nov 2013 22:11:01 +0000] Issue #2089139 by jonathan1055: Typos in /->promoted and /->moderated fixed.

Half of them are PHP notices fixes. The remaining ones do fix rendering issues. Especially the change in contribs/weblinks_blocks fixes a "Fatal error: [] operator not supported for strings in includes/theme.inc".

Regarding testing: jonathan1055 discovered most of the issues and I assume he tested them accordingly. Second a few changes are backports from the D7 version which were rolled out many months ago. Third I have tested all the changes before I committed them on my test site. And you are invited to review these changes.

Gerhard

Sounds like it could be time. i'll leave it to your discretion.

@Nancy: yes, it's time to release a new version. But I will wait a while since a new issue was reported by Jonathan this morning.

@Jonathan: I think there is no need to re-test the changes. I've done also a lot of testing. One question: did you also test my changes?

Gerhard

Should we punish Jonathan by making him a maintainer? ;)

Great idea!

Gerhard

Done

OK. Do I still have commit rights?

Gerhard

Yes

Apply to the webmasters for a git account. If you need me to, I'll endorse your application. I thought it would only allow me to add people with a git account, but I guess I was wrong.

@Jonathan: #14: I thought you might be surprised.

Anyway, you don't need a specific git account really. You still use your drupal.org account for git access, but you need to setup git access in your profile. How to do this is documented quite well.

#15: about testing: I assumed you have a test site running where you are using an up-to-date Web Links dev package downloaded from drupal.org. Or did you apply only your own changes to your test site?

Gerhard

At the top of the project page, you'll see "Version control". That will show you the git commands for each branch. When you do a git clone, you'll have everything that has been committed.