Image styles are using the machine name of the style instead of the actual label. Attached is a patch to fix that issue.

CommentFileSizeAuthor
#4 insert-fix_image_label-2170455-4.patch534 bytesprogpapa
insert_fix_image_label.patch772 bytessambfries

Comments

nielsaers’s picture

nielsaers commented

Patch works

bskibinski’s picture

bskibinski
Primary language Dutch
Location Breda, The Netherlands
commented

Tested and works.

malberts’s picture

malberts commented
Version: 7.x-1.3 » 7.x-1.x-dev
Status: Active » Needs review

This look simple enough and I haven't had any issues.

I suspect, but haven't tested, that if you use this patch with an older version of Drupal before image styles got labels it might give a PHP notice.

progpapa’s picture

progpapa commented
StatusFileSize
new insert-fix_image_label-2170455-4.patch534 bytes

I haven't tested it with older versions of Drupal, but if there were PHP notices, this patch should fix those + I've added some sanitization, since image style names are user entered data.

AndyThornton’s picture

AndyThornton commented

+1

Thanks for this fix, I applied the patch it and it works fine.

mkolar’s picture

mkolar commented
Status: Needs review » Reviewed & tested by the community

Thanks for the fix.

Jej’s picture

Jej commented

Quite better, thanks!

  • Snater committed f40935e on 7.x-1.x authored by progpapa 
    Issue #2170455 by progpapa, sambfries: Image Styles using machine name...
snater’s picture

snater commented
Status: Reviewed & tested by the community » Needs review
snater’s picture

snater commented
Status: Needs review » Fixed

https://www.drupal.org/project/insert/releases/7.x-1.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.