Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
cache system
Priority:
Major
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
8 Jan 2014 at 15:04 UTC
Updated:
29 Jul 2014 at 23:16 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sunFull conversion of all instances + use statements throughout core, courtesy of @dawehner + phpStorm ;)
For now, I'm intentionally leaving the BC-shim in place; i.e.:
Doing so should hopefully break less patches in the queue right now.
And perhaps we even want to retain that as-is (not marking CacheBackendInterface::CACHE_PERMANENT as @deprecated). Technically, the constant/value is not really owned by CacheBackend, but would rather belong to a (non-existing) CacheItem class, since it is the cache item that declares when it wants to expire.
Since there is no CacheItem class, and also, given our current efforts that are seemingly moving all of the remainders of cache.inc into the Cache class, the Cache class appears to be the most appropriate home for now.
Comment #2
larowlan+1
Comment #4
sun1: drupal8.cache-dx.1.patch queued for re-testing.
Comment #5
sunBack to green.
Comment #6
longwave+1 to improving DX here.
Noted a one line whitespace issue, corrected in the attached patch, otherwise this looks RTBC to me.
Comment #7
dawehnerI certainly like that we don't expose that internal anymore.
Comment #8
webchickWell that's definitely a heck of a lot nicer.
However, unfortunately (and not surprisingly) no longer applies.
Comment #9
damiankloip commentedRerolled.
Comment #11
damiankloip commentedWhoops, sorry. We don;t want to be trying to use the same class twice.
Comment #13
damiankloip commentedOver zealous with the CacheBackendInterface removal in EntityManager.. Sorry for the noise.
Comment #14
longwaveLooks good.
Comment #15
sunQuoting myself:
Please note that work on a CacheItem class + interface happens in #1748022: Make CacheBackendInterface::get() return a proper class
That said, even with that, the DX of
Cache::PERMANENTwould still be much nicer thanCacheItemInterface::PERMANENT.Comment #16
webchickGetting this in while it's hot!
Committed and pushed to 8.x. Thanks!
Change notice time.
Comment #17
jessebeach commentedChange notice authored: https://drupal.org/node/2182907
Comment #18
jessebeach commentedComment #19
jibranThanks for the change notice @jessebeach. I have updated minor doc issues and removed approved change line please review. https://drupal.org/node/2182907/revisions/view/6870919/6871249