Updated: Comment #N

Problem/Motivation

The link 

 * Follow best practices:
   http://drupal.org/best-practices

is a site builder link.

Proposed resolution

Move link to site-builder section and add the correct developer link.

Remaining tasks

  • Is it worth to introduce a Component for all *.txt files? As the documentation component covers way more.
  • The link to https://drupal.org/node/287350 Programming best practices needs an alias programming-best-practices

User interface changes

API changes

CommentFileSizeAuthor
#3 core-readme-links-2168587-3-do-not-test.patch3.35 KBclemens.tolboom
core-readme-links.patch913 bytesclemens.tolboom

Comments

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Issue summary: View changes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Good idea. But I think we should link to
https://drupal.org/developing/best-practices
(which I just added an alias to) in the programming section instead.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new core-readme-links-2168587-3-do-not-test.patch3.35 KB

Attached patch has

- new link to https://drupal.org/developing/best-practices
- all link to d.o protocol changed from http:// to https://

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks! Looks correct to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Normal » Minor

Since this doesn't actually break anything, moving to minor priority to separate it out into those things we can commit at any time.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

@webchick: I disagree as this could help with ie http://cheppers.com/blog/global-sprint-weekend-january-25-and-26-2014

Also related issues could require a re-roll :-/

So please change policy: commit when ready

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Minor vs. normal doesn't affect when it gets committed, it simply filters out changes that aren't functional bugs from those that are so they can be surfaced more easily.

Anyway, reviewed this tonight and can confirm jhodgdon's RTBC.

Committed and pushed to 8.x.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

Oepsie :)

Although I still don't get

to separate it out into those things we can commit at any time

:-/

Thanks anyway.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.