Not sure about the other browsers, but in Google Chrome on a MAC the view is cutoff.

Not working

It works correctly after adding:

.cke_dialog_ui_vbox{
  height: 100% !important;
}

Working

I'm not sure which css file to put it in?
node_embed/ckeditor/ck_nodeembed.css or
node_embed/plugins/node_embed/node_embed.css

Let me know and I can make a patch.

CommentFileSizeAuthor
#10 node_embed-workaround_ckeditor_4.x_missing_dialog_height-2167591-10.patch458 bytesmvwensen
node-embed-working.jpg68.14 KBgmclelland
node-embed-not-working-correctly.jpg44.96 KBgmclelland

Comments

mrharolda’s picture

mrharolda commented
Status: Active » Postponed (maintainer needs more info)

Can you check if this is still the case in the latest -dev version?

agileadam’s picture

agileadam
Location Maine, USA
commented

While I cannot confirm that the issue is present in the latest dev version(s), I can confirm this bug exists with ckeditor-7.x-1.15 and 7.x-1.1.

Adding the css declaration to node_embed/ckeditor/ck_nodeembed.css did not work for me (even after many Drupal and browser cache clears.

Adding the declaration to node_embed/plugins/node_embed/node_embed.css did work, however.

Thanks!

mrharolda’s picture

mrharolda commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

While I cannot confirm that the issue is present in the latest dev version(s), I can confirm this bug exists with ckeditor-7.x-1.15 and 7.x-1.1.

Well, since we both can't reproduce it, I'm closing this issue as ... 'cannot reproduce' ;)

Feel free to re-open it once it's confirmed this isn't fixed in the latest -dev!

pcuttriss’s picture

pcuttriss commented

Hi Harold

I have exactly the same issue and have tested against the latest dev version:

7.x-1.x-dev tar.gz (16.27 KB) | zip (22.65 KB) 2014-Sep-24

I have used IE 11 on Windows 7 with the same result.

Without the update to node_embed.css I get a one third height dialog box, with the update I get a full height dialog as per the original examples.

All Drupal and browser caches cleared at each stage.

More than happy to help test any changes if needed.

Paul C

mrharolda’s picture

mrharolda commented
Status: Closed (cannot reproduce) » Needs work

Ok, so this is still an active bug, but ... I don't want to add an !important to the css ...

Any other suggestions?

sreynen’s picture

sreynen commented

I suggest starting by looking at the CSS that's causing the problem. There's no reference to cke_dialog_ui_vbox within the node_embed copy of ckeditor, so I'm guessing that's coming from a separate install, maybe something in sites/all/libraries/. This may be a bug in ckeditor's CSS, in which case an upstream patch is more appropriate than overriding the CSS in Drupal. If the problem is Drupal-specific or Node Embed-specifc, it should be overridden within whatever specific context it appears.

creatile’s picture

creatile commented

I suppose the css should be added in sites/all/libraries/ckeditor/skins/moono/dialog.css

.cke_dialog_ui_vbox{height: 100%;}

This solution worked for me

mrharolda’s picture

mrharolda commented
Status: Needs work » Postponed

I suppose the css should be added in sites/all/libraries/ckeditor/skins/moono/dialog.css

... which makes this an upstream bug.

Can somebody address this in the Ckeditor bug tracker and post the link here?

russellb’s picture

russellb commented

For now I've fixed the problem by adding the following to my theme css file:

.cke_reset_all .cke_dialog_ui_vbox {
  height: 100%;
}
mvwensen’s picture

mvwensen commented
Status: Postponed » Needs review
StatusFileSize
new node_embed-workaround_ckeditor_4.x_missing_dialog_height-2167591-10.patch458 bytes

Created a patch adding the workaround to node_embed.
Issue on ckeditor 4.x exists for 3 years now and is still not fixed.
https://dev.ckeditor.com/ticket/11034