Updated: Comment #1

Problem/Motivation

In the docs it is is not clear that the last two parameters of db_select() are optional.

Proposed resolution

Update docblock to include (optional).

Remaining tasks

Review patch.

User interface changes

API changes

CommentFileSizeAuthor
#3 2167379-3.patch773 bytesfilijonka
#1 drupal-db-select-params-docs-optional-2167379-1.patch773 bytesElijah Lynn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Elijah Lynn’s picture

Elijah Lynn
Location Portland, Oregon
CreditAttribution: Elijah Lynn commented
FileSize
drupal-db-select-params-docs-optional-2167379-1.patch773 bytes
Elijah Lynn’s picture

Elijah Lynn
Location Portland, Oregon
CreditAttribution: Elijah Lynn commented
Issue summary: View changes
Status: Active » Needs review
filijonka’s picture

filijonka CreditAttribution: filijonka commented
FileSize
2167379-3.patch773 bytes

clean reroll

filijonka’s picture

filijonka CreditAttribution: filijonka commented
Status: Needs review » Reviewed & tested by the community

well was reviewing pathc in #1 and was going to set it green when realising it needed a reroll. The reroll was no changes so sets this to green.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 4b7a940 and pushed to 8.0.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

This issue is a prioritized change (documentation) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption.

  • alexpott committed 4b7a940 on 8.0.x 
    Issue #2167379 by Elijah Lynn, filijonka: db_select docblock should list...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.