Files: 
CommentFileSizeAuthor
#7 drupal8.bootstrap-variables-die.7.patch7.74 KBsun
FAILED: [[SimpleTest]]: [MySQL] 59,080 pass(es), 274 fail(s), and 19 exception(s). View
drupal8.bootstrap-variables-die.0.full_.patch6.74 KBsun
FAILED: [[SimpleTest]]: [MySQL] 59,375 pass(es), 273 fail(s), and 17 exception(s). View
drupal8.bootstrap-variables-die.0.patch7.08 KBsun
FAILED: [[SimpleTest]]: [MySQL] 59,314 pass(es), 272 fail(s), and 17 exception(s). View

Comments

The last submitted patch, drupal8.bootstrap-variables-die.0.patch, failed testing.

ianthomas_uk’s picture

+++ b/core/includes/bootstrap.inc
@@ -876,6 +871,11 @@ function variable_initialize($conf = array()) {
+  // @todo D8: Temporary hack until full removal.
+  if (!isset($conf)) {
+    $conf = variable_initialize(isset($conf) ? $conf : array());
+  }
+

What is the advantage of removing DRUPAL_BOOTSTRAP_VARIALBES before removing the variable subsystem?

This backwards compatibility hack looks fairly safe, but I'd hate for us to waste time tracking down bugs it introduced when we could have just waited.

Status: Needs review » Needs work

The last submitted patch, drupal8.bootstrap-variables-die.0.full_.patch, failed testing.

xjm’s picture

Priority: Normal » Critical
Issue tags: +beta blocker

This is either critical and a beta blocker in its own right, or a duplicate of #2167109: Remove Variable subsystem. I think it's fine to scope it separately for now and then mark it duplicate later if needed.

ianthomas_uk’s picture

On further thought, I think the backwards compatibility code would be broken by someone setting $conf in settings.php. Is it better just to do this as part of #2167109: Remove Variable subsystem?

larowlan’s picture

This will be blocked on the language cmi conversions.

sun’s picture

Status: Needs work » Needs review
FileSize
7.74 KB
FAILED: [[SimpleTest]]: [MySQL] 59,080 pass(es), 274 fail(s), and 19 exception(s). View

Interesting. Given a test failure difference of 1 between both patches, and the fact that non-language related tests passed, I wonder how attached patch performs - copypasting the lazy-instantiation concept to _set() + _del(). :)

Status: Needs review » Needs work

The last submitted patch, 7: drupal8.bootstrap-variables-die.7.patch, failed testing.

sun’s picture

Status: Needs work » Closed (duplicate)
xjm’s picture

Issue tags: -beta blocker