Follow-up to #2159501: Remove DRUPAL_BOOTSTRAP_DATABASE

Focus on removing the bootstrap phase (only).

Blocked on:

CommentFileSizeAuthor
#7 drupal8.bootstrap-variables-die.7.patch7.74 KBsun
drupal8.bootstrap-variables-die.0.full_.patch6.74 KBsun
drupal8.bootstrap-variables-die.0.patch7.08 KBsun

Comments

The last submitted patch, drupal8.bootstrap-variables-die.0.patch, failed testing.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented 
+++ b/core/includes/bootstrap.inc
@@ -876,6 +871,11 @@ function variable_initialize($conf = array()) {
+  // @todo D8: Temporary hack until full removal.
+  if (!isset($conf)) {
+    $conf = variable_initialize(isset($conf) ? $conf : array());
+  }
+

What is the advantage of removing DRUPAL_BOOTSTRAP_VARIALBES before removing the variable subsystem?

This backwards compatibility hack looks fairly safe, but I'd hate for us to waste time tracking down bugs it introduced when we could have just waited.

Status: Needs review » Needs work

The last submitted patch, drupal8.bootstrap-variables-die.0.full_.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Normal » Critical
Issue tags: +beta blocker

This is either critical and a beta blocker in its own right, or a duplicate of #2167109: Remove Variable subsystem. I think it's fine to scope it separately for now and then mark it duplicate later if needed.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented

On further thought, I think the backwards compatibility code would be broken by someone setting $conf in settings.php. Is it better just to do this as part of #2167109: Remove Variable subsystem?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

This will be blocked on the language cmi conversions.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new drupal8.bootstrap-variables-die.7.patch7.74 KB

Interesting. Given a test failure difference of 1 between both patches, and the fact that non-language related tests passed, I wonder how attached patch performs - copypasting the lazy-instantiation concept to _set() + _del(). :)

Status: Needs review » Needs work

The last submitted patch, 7: drupal8.bootstrap-variables-die.7.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Closed (duplicate)

Merged into #2167109: Remove Variable subsystem

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: -beta blocker