We have two similar View subscribers: HtmlViewSubscriber(_content), ViewSubscriber(_controller). the onHml is overlapped. It seems is not used anymore. So we remove onHTML event from ViewSubscriber.

CommentFileSizeAuthor
#1 2167071-onhtml_deprecated-1.patch1.74 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new 2167071-onhtml_deprecated-1.patch1.74 KB

Status: Needs review » Needs work

The last submitted patch, 1: 2167071-onhtml_deprecated-1.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented

Yeah! This is a clear sign that the _controller in config_translation as well as the _controller in system.routing.yml for the page cache are the only places which require that code. If both places are fixed we can indeed drop it.

Anonymous’s picture

Anonymous (not verified) commented

Yes. At first we should solve this https://drupal.org/node/2167039. Afterwards the test will be passed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

1: 2167071-onhtml_deprecated-1.patch queued for re-testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

So let's remove dead code

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2167071-onhtml_deprecated-1.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

1: 2167071-onhtml_deprecated-1.patch queued for re-testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 6ac9760 on 8.x by catch: 
    Issue #2167071 by likin: Remove onHTML event from ViewSubscriber -...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.