We have two similar View subscribers: HtmlViewSubscriber(_content), ViewSubscriber(_controller). the onHml is overlapped. It seems is not used anymore. So we remove onHTML event from ViewSubscriber.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 2167071-onhtml_deprecated-1.patch | 1.74 KB | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) commentedComment #3
dawehnerYeah! This is a clear sign that the _controller in config_translation as well as the _controller in system.routing.yml for the page cache are the only places which require that code. If both places are fixed we can indeed drop it.
Comment #4
Anonymous (not verified) commentedYes. At first we should solve this https://drupal.org/node/2167039. Afterwards the test will be passed.
Comment #5
Anonymous (not verified) commented1: 2167071-onhtml_deprecated-1.patch queued for re-testing.
Comment #6
andypostSo let's remove dead code
Comment #8
Anonymous (not verified) commented1: 2167071-onhtml_deprecated-1.patch queued for re-testing.
Comment #9
andypostComment #10
catchCommitted/pushed to 8.x, thanks!