We introduced a small CSS syntax error when fixing #2100133: The Toolbar tray box shadow disappears at small viewports sizes on Chrome, on a Mac, under unpredictable conditions.

The code was committed as this

  border-left: 1px solid #aaaaaa;
[dir="rtl"] .toolbar .toolbar-tray-vertical {
  border-right: 0 none;
  box-shadow: 1px 0 5px 2px rgba(0, 0, 0, 0.3333);
}

With the left border value for the RTL styling outside the selector declaration. It should be

[dir="rtl"] .toolbar .toolbar-tray-vertical {
  border-left: 1px solid #aaaaaa;
  border-right: 0 none;
  box-shadow: 1px 0 5px 2px rgba(0, 0, 0, 0.3333);
}

Comments

jessebeach’s picture

Status: Active » Needs review
StatusFileSize
new1.11 KB

This is a one-liner just moving existing code around to remove a syntax error.

sam152’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. I may need to re-roll "#1663198: Clean up toolbar css" if this gets in.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Normally I would make the smaller patch re-roll for the larger patch, but since this is fixing an actual functional bug, I'd like to get it in first. Sorry, PerthSam152. Hopefully the re-roll in the other issue will be pretty easy; thanks for your work on that!

Committed and pushed to 8.x. Thanks!

sam152’s picture

Easy fix. Re-roll of #1663198: Clean up toolbar css complete if anyone wants to review it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.