Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Ubercart does not provide RTL support. all css styles are ltr only.
Please add right-to-left support in stylesheets.
| Comment | File | Size | Author |
|---|---|---|---|
| #32 | 2162483-32-rtl.patch | 16 KB | TR |
| #31 | 2162483-31-rtl.patch | 16 KB | TR |
| |||
| #15 | ubercart-rtl_support-2162483-15.patch | 18.24 KB | herom |
| #14 | 3.jpeg | 120.46 KB | Hadi Farnoud |
| #14 | 2.jpeg | 48.63 KB | Hadi Farnoud |
Comments
Comment #1
TR CreditAttribution: TR commentedCan you provide specific details about what needs to be fixed? Or perhaps a patch?
Much of our markup is styled by core Drupal, but we will certainly change any Ubercart-specific CSS that doesn't support RTL. We just don't know what that is right now ...
Comment #2
hejazee CreditAttribution: hejazee commentedYes, I'm working on it and I will solve the problem. but I may need some help by others.
None of the css files have a matching rtl file.
for example uc_cart.css is there, but uc_cart-rtl.css is missing.
In the UI, rtl does not work correctly.
I'm creating rtl css files and I'll create a patch for this.
Comment #3
hejazee CreditAttribution: hejazee commentedComment #4
hejazee CreditAttribution: hejazee commentedPlease test this patch.
Comment #5
TR CreditAttribution: TR commentedLet the testbot look first.
Comment #6
hejazee CreditAttribution: hejazee commentedDoes the test bot, test css files?
as far as i know, css files can not be tested with drupal's testing framework!
Comment #7
Hadi Farnoud CreditAttribution: Hadi Farnoud commentedit's not clear what the issue is with current rtl css files.
please explain the problem and the areas you have fixed. otherwise, don't expect someone test all ubercart for you
Comment #8
hejazee CreditAttribution: hejazee commentedIf you look at my patch, you can see that I have created all -rtl files.
They are:
Most important items include:
Comment #9
TR CreditAttribution: TR commentedHejazee: Can you please add
/* LTR */comments into the main .css files for the styles you're overriding? This is part of the Drupal coding standards explained at Supporting "right to left" (RTL) languages. These comments will identify the styles that are direction specific, so if we ever change them in the future (likely!) we will know to make the same changes in the RTL files.I don't see anything wrong with your .css files, but I don't have a good way to test them myself.
For CSS changes, the test bot is used only to make sure the patch applies and doesn't contain any syntax errors.
Comment #10
Hadi Farnoud CreditAttribution: Hadi Farnoud commentedThere are no Ubercart Persian translation Hejazee.
I did test your patch in English language (Persian lang selected though). it looks fine to me although it would've been better to test it in Persian.
Comment #11
herom CreditAttribution: herom commentedremoved some unnecessary -rtl.css code. also, added
/* LTR */comments mentioned in #9. (separate interdiffs added for easier review).some before/after screenshots would be very helpful here, too (that unfortunately I could not make, due to some config issues with ubercart).
Comment #12
Hadi Farnoud CreditAttribution: Hadi Farnoud commentedHejazee, please upload the translation as well. Or just review and accept them on localisation server.
Comment #13
hejazee CreditAttribution: hejazee commentedI think there is a problem with localize.drupal.org
because translations of new releases of modules and drupal core are not available.
you can download translations from this page:
https://localize.drupal.org/translate/languages/fa/export
select the latest release which is available in the list.
Comment #14
Hadi Farnoud CreditAttribution: Hadi Farnoud commentedlooks fine to me
Comment #15
herom CreditAttribution: herom commentedadded a padding fix for uc_cart_block links.
there is still an issue with the "cart-block-arrow" in uc_cart_block, that appears only in firefox. I have added screenshots for that.
Comment #16
herom CreditAttribution: herom commentedumm... let's get the testbot on the patch. then I'll change back to "needs work".
Comment #17
herom CreditAttribution: herom commentedComment #18
Hadi Farnoud CreditAttribution: Hadi Farnoud commented@herom:
testbot does not validate css syntax. it just check that your patch applies.
for easier review, you can use simplytest.me. in advanced, you can add ubercart and apply the patch.
Comment #19
Hadi Farnoud CreditAttribution: Hadi Farnoud commentedComment #20
TR CreditAttribution: TR commentedThe reason it's in "Needs work" is because of #15: "there is still an issue with the "cart-block-arrow" in uc_cart_block, that appears only in firefox." If we get a new patch with that item fixed then it can be reviewed again.
Comment #21
W.M. CreditAttribution: W.M. commentedThere seems not -rtl files inside Ubercart module folders. I hope that the above listed patches get embedded in next stable releases.
Comment #22
TR CreditAttribution: TR commented@W.M.: Please test the patch in #15 and please help correct the problem with "cart-block-arrow". The fix can only be made if people like you who use RTL get involved.
Comment #23
hejazee CreditAttribution: hejazee as a volunteer commentedReset issue summary. (it had been removed)
Comment #24
hejazee CreditAttribution: hejazee as a volunteer commented#15: I don't see this bug in current version of firefox (version 42)
I will review this patch again and update the issue afterwards.
Comment #25
TR CreditAttribution: TR commented@hejazee: If you can verify the patch still works I'd like to commit the patch now. It's certainly better than what we have, and if any issues show up because of it we can fix them later.
Comment #26
hejazee CreditAttribution: hejazee as a volunteer commentedI have tested the latest patch in a few sites.
Looks good. I don't see any problem.
Comment #27
hejazee CreditAttribution: hejazee as a volunteer commentedComment #28
TR CreditAttribution: TR commentedThank you for all the hard work to make this happen! I'm glad this is finally done.
Patch from #15 was committed to 7.x-3.x, leaving this open to be ported to 8.x-4.x.
If any problems arise with the RTL css from this patch, please open a new follow-up issue.
Comment #30
hejazee CreditAttribution: hejazee as a volunteer commentedThank you @TR.
Set status to "Needs work"
Comment #31
TR CreditAttribution: TR commentedHere's a port to D8. I used the D7 patch as a guideline.
NOT TESTED!
Comment #32
TR CreditAttribution: TR commentedMade two minor changes, patch attached. I am just going to commit this without review because I want to lock in the RTL goodness before 8.x-4.x CSS diverges too much more from the 7.x-3.x stuff. If a problem arises with RTL support in D8 we can correct it in a separate issue.