The error message started to appear when the hosting service upgraded to PHP 5.4 with the default strict error setting.
The attached patch gets rid of this annoying error message in the most simpleminded way.

CommentFileSizeAuthor
#5 captcha_6_php5.4.patch671 bytesgnassar
#4 captcha_6_php5.4.patch654 bytesgnassar
captcha_6_php5.4.patch791 bytesehowland
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

superspring’s picture

superspring CreditAttribution: superspring commented
Status: Active » Reviewed & tested by the community

This works for me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, captcha_6_php5.4.patch, failed testing.

yadranko’s picture

yadranko CreditAttribution: yadranko commented

The patch states:
sites/all/modules/contrib/captcha/captcha.inc instead of
sites/all/modules/captcha/captcha.inc without the contrib part.

That could be where the problem is.

gnassar’s picture

gnassar CreditAttribution: gnassar commented
FileSize
captcha_6_php5.4.patch654 bytes

Resubmitting with proper paths.

gnassar’s picture

gnassar CreditAttribution: gnassar commented
FileSize
captcha_6_php5.4.patch671 bytes

Actually, the problem is (also) that lines are truncated in the patch. Resubmitting with truncated lines fixed.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland commented

Is this patch ready to go?

yan’s picture

yan CreditAttribution: yan commented
Status: Needs work » Needs review

Patch from #5 seems to solve the problem for me.

Status: Needs review » Needs work

The last submitted patch, 5: captcha_6_php5.4.patch, failed testing.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland commented

The patch needs to be re-rolled.

Status: Needs work » Needs review

Liam Morland queued 5: captcha_6_php5.4.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: captcha_6_php5.4.patch, failed testing.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland commented
Version: 6.x-2.3 » 6.x-2.x-dev
Status: Needs work » Needs review

Funny, the patch applies fine when I tried it.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland commented
Status: Needs review » Reviewed & tested by the community
wundo’s picture

wundo CreditAttribution: wundo commented
Status: Reviewed & tested by the community » Fixed

Committed :)

  • wundo committed 37ef148 on 6.x-2.x 
    Issue #2162437 by gnassar, ehowland: PHP 5.4 strict warning: Only...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs review

FrancoisL queued 5: captcha_6_php5.4.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: captcha_6_php5.4.patch, failed testing.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Status: Needs work » Closed (fixed)

Patch is already applied.

vrajak@gmail.com’s picture

vrajak@gmail.com CreditAttribution: vrajak@gmail.com as a volunteer commented

Sorry, where is the patch applied? The dev version of Captcha 6.x? I have this error and I don't know if I should try and patch it, or just use the dev version..Thanks!

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented

It was committed to 6.x-2.x. You'll have to use the development release to get it.