image_get_random() not filtering by term

• This is issue is still valid: image.module doesn't implement what it says it does.
• Impact is minimal because I can't find any usages of "image_get_random", except in the blocks of "image module" where $tid is not used (since it can't be set anyway)

Attached is an updated patch, that also implements the same in "image_get_latest".

Optionally:

• I'm wondering if "image_get_latest" can be used in "image_page" where a similar db_query is done to get the latest image of a set of $tids. The "image_get_latest" (and why not "image_get_random" too) should then be changed to accept a list of $tids, eg with a if(!is_array($tid)) $tids =array($tid); else $tids = $tid;
• Only problem with this is that the "ORDER BY" is different in "image_get_latest" (changed DESC) and "image_page" (n.sticky DESC, n.created DESC). Is there a reason for this?

I've tested that this works. It surely doesn't break anything (because $tid is not used).

fixed, cvs.

i found a bug...
the node add image function disapear ???
whith your patch

This still needs to be fixed in 4.6

This version is no longer supported. If this issue is occurring with a more recent version please open a new issue.