[D8] Patch testing issue [#2160791]

Comment	File	Size	Author
#224	2160791-224.patch	580 bytes	tr
#221	unused-use.patch	10.07 KB	longwave
#219	url-deprecated.patch	47.4 KB	tr
#218	uc_role-postgres.patch	575 bytes	longwave
#214	no-rules.patch	300 bytes	longwave
#210	fix-catalog-taxonomy-field.patch	1.61 KB	longwave
#207	remove-checkout-pane-hook.patch	12.41 KB	longwave
#206	checkout-quote-pane.patch	12.2 KB	longwave
#199	improve-address-class.patch	4.05 KB	longwave
#197	modern-store-report.patch	3 KB	longwave
#195	modern-store-report.patch	2.22 KB	longwave
#194	t.patch	20.05 KB	tr
#192	t.patch	20.06 KB	tr
#190	t.patch	20.04 KB	tr
#188	format.patch	13.1 KB	tr
#184	settings-to-config.patch	58.11 KB	longwave
#181	settings-to-config.patch	57.01 KB	longwave
#179	inject.patch	111.31 KB	tr
#177	order-status-delete.patch	5.12 KB	longwave
#173	order-view.patch	6.59 KB	longwave
#172	uc_order_status_options_list.patch	8.93 KB	longwave
#171	order-status-delete.patch	5.58 KB	longwave
#167	order-status-delete.patch	3.73 KB	longwave
#166	country.patch	9.37 KB	tr
#163	status.patch	15.96 KB	tr
#161	same-address-pane-config.patch	4.1 KB	longwave
#159	same-address-pane-config.patch	4.2 KB	longwave
#158	uc_store-twig.patch	4.68 KB	longwave
#156	entity-api-3.patch	7.31 KB	tr
#153	uc_store-twig.patch	4.65 KB	longwave
#152	uc_order_load.patch	18.62 KB	longwave
#151	entity-api-2.patch	9.05 KB	tr
#150	entity_load.patch	6.13 KB	longwave
#149	entity_create.patch	5.19 KB	longwave
#148	payment-settings-metadata.patch	8.46 KB	longwave
#147	entity-api-insteadof-db_query.patch	10.87 KB	tr
#146	hide-zero-weight-dimensions.patch	3.62 KB	longwave
#144	uc_store-twig.patch	4.48 KB	longwave
#142	remove-hook_uc_order.patch	26.05 KB	longwave
#140	remove-hook_uc_order.patch	25.52 KB	longwave
#139	remove-hook_uc_order.patch	26.01 KB	longwave
#138	order-data-types.patch	2.85 KB	longwave
#136	deprecated_functions.patch	96.87 KB	longwave
#134	filter_xss.patch	10.28 KB	longwave
#133	uc_order_load_line_items.patch	14.72 KB	longwave
#132	uc_order_load_line_items.patch	0 bytes	longwave
#126	uc_order_load_line_items.patch	14.68 KB	longwave
#125	uc_line_items_calculate.patch	1.42 KB	longwave
#123	uc_line_items_calculate.patch	1.42 KB	longwave
#122	uc_order_load_line_items.patch	14.68 KB	longwave
#120	remove-hook_uc_order.patch	19.3 KB	longwave
#119	product-base-fields.patch	37.87 KB	longwave
#116	product-base-fields.patch	37.1 KB	longwave
#114	product-base-fields.patch	26.76 KB	longwave
#112	product-base-fields.patch	16.14 KB	longwave
#110	product-base-fields.patch	12.29 KB	longwave
#109	country-cmi.patch	749.27 KB	longwave
#107	country-cmi.patch	743.35 KB	longwave
#106	country-cmi.patch	743.39 KB	longwave
#104	country-cmi.patch	743.37 KB	longwave
#103	chasing-head.patch	41.02 KB	longwave
#101	chasing-head.patch	39.54 KB	longwave
#99	chasing-head.patch	37.42 KB	longwave
#96	chasing-head.patch	20.19 KB	longwave
#94	country-cmi.patch	743.4 KB	longwave
#92	country-cmi.patch	743.4 KB	longwave
#91	simplify-tests.patch	7.78 KB	longwave
#89	add-to-cart-form.patch	17.67 KB	longwave
#87	add-to-cart-form.patch	17.67 KB	longwave
#86	use-statements.patch	20.94 KB	longwave
#85	remove-hook-forms.patch	12.6 KB	longwave
#81	remove-hook-forms.patch	9.45 KB	longwave
#78	remove-hook-forms.patch	9.72 KB	longwave
#72	remove-hook-forms.patch	9.14 KB	longwave
#70	line-item-cmi.patch	1.61 KB	longwave
#69	uc_cart-add_item_msg.patch	4.41 KB	longwave
#67	config-base-class.patch	21.39 KB	longwave
#66	same-address-pane-config.patch	4.24 KB	longwave
#64	simplify-uc_cart_get_contents.patch	3.15 KB	longwave
#63	simplify-uc_cart_get_contents.patch	2.96 KB	longwave
#62	checkout-pane-plugin-config.patch	16.54 KB	longwave
#60	checkout-pane-plugin-config.patch	16.54 KB	longwave
#59	checkout-pane-plugin-config.patch	15.54 KB	longwave
#58	remove-add-to-cart-theme.patch	3.08 KB	longwave
#57	stock-settings-cmi.patch	7.28 KB	longwave
#56	cart-messages-cmi.patch	8.35 KB	longwave
#55	simplify-uc_cart_complete_sale.patch	3.08 KB	longwave
#54	product-kit-settings-cmi.patch	3.5 KB	longwave
#53	checkout-pane-cmi.patch	5.98 KB	longwave
#52	twig-uc_cart_block_title.patch	3.75 KB	longwave
#51	twig-uc_payment_totals.patch	4.35 KB	longwave
#48	twig-uc_payment_totals.patch	4.49 KB	longwave
#47	remove-unused-description.patch	11.56 KB	longwave
#46	remove-uc_weight_sort.patch	6.19 KB	longwave
#45	remove-uc_weight_sort.patch	2.45 KB	longwave
#42	interdiff.txt	3.87 KB	longwave
#42	payment-checkout-pane-plugin.patch	13.33 KB	longwave
#41	payment-checkout-pane-plugin.patch	11.98 KB	longwave
#40	uc_cart-theme-merge.patch	11.45 KB	longwave
#39	address-pane-plugin.patch	14.49 KB	longwave
#37	address-pane-plugin.patch	14.45 KB	longwave
#34	checkout-pane-plugins-2.patch	26.29 KB	longwave
#34	drupal_add_css.patch	1.38 KB	longwave
#32	checkout-pane-plugins.patch	5.34 KB	longwave
#31	checkout-pane-review.patch	2.93 KB	longwave
#30	interdiff.txt	5.39 KB	longwave
#30	checkout-pane-plugin-manager.patch	22.49 KB	longwave
#26	checkout-pane-plugin-manager.patch	20.31 KB	longwave
#23	checkout-pane-plugin-manager.patch	18.49 KB	longwave
#22	checkout-pane-plugin-manager.patch	17.48 KB	longwave
#21	uc_payment_method_list-cleanup.patch	9.33 KB	longwave
#20	cod-payment-plugin.patch	15.81 KB	longwave
#19	payment-pack-plugins.patch	34.77 KB	longwave
#18	payment-pack-plugins.patch	29.43 KB	longwave
#17	check-payment-plugin.patch	11.52 KB	longwave
#16	free-order-payment-plugin.patch	7.52 KB	longwave
#15	free-order-payment-plugin.patch	6.42 KB	longwave
#14	payment-method-plugins.patch	40.03 KB	longwave
#12	payment-method-plugins.patch	42.46 KB	longwave
#9	payment-method-plugins.patch	41.89 KB	longwave
#7	payment-method-plugins.patch	39 KB	longwave
#5	payment-method-plugins.patch	38.94 KB	longwave
#4	access.patch	29.52 KB	tr
#3	clt.patch	10.79 KB	tr
	simplify-uc_cart_complete_sale.patch	3 KB	longwave

Comment #1

20 December 2013 at 22:38

Status:

Needs review

» Needs work

The last submitted patch, simplify-uc_cart_complete_sale.patch, failed testing.

Log in or register to post comments

Comment #3

tr commented 22 December 2013 at 23:18

Status:

Needs work

» Needs review

Status	File	Size
new	clt.patch	10.79 KB

just testing ...

Log in or register to post comments

Status	File	Size
new	access.patch	29.52 KB

Status	File	Size
new	payment-method-plugins.patch	38.94 KB

Comment #6

30 December 2013 at 00:03

Status:

Needs review

» Needs work

The last submitted patch, 5: payment-method-plugins.patch, failed testing.

Log in or register to post comments

Status	File	Size
new	payment-method-plugins.patch	39 KB

Status	File	Size
hidden	payment-method-plugins.patch	38.94 KB

Comment #8

30 December 2013 at 00:21

Status:

Needs review

» Needs work

The last submitted patch, 7: payment-method-plugins.patch, failed testing.

Log in or register to post comments

Status	File	Size
new	payment-method-plugins.patch	41.89 KB

Status	File	Size
hidden	payment-method-plugins.patch	39 KB

Comment #10

longwave

he/him

English

UK

commented 30 December 2013 at 00:40

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #11

30 December 2013 at 01:09

Status:

Needs review

» Needs work

The last submitted patch, 9: payment-method-plugins.patch, failed testing.

Log in or register to post comments

Status	File	Size
new	payment-method-plugins.patch	42.46 KB

Status	File	Size
hidden	payment-method-plugins.patch	41.89 KB

Comment #13

30 December 2013 at 01:53

Status:

Needs review

» Needs work

The last submitted patch, 12: payment-method-plugins.patch, failed testing.

Log in or register to post comments

Status	File	Size
new	payment-method-plugins.patch	40.03 KB

Status	File	Size
hidden	payment-method-plugins.patch	42.46 KB

Status	File	Size
new	free-order-payment-plugin.patch	6.42 KB

Status	File	Size
hidden	payment-method-plugins.patch	40.03 KB

Status	File	Size
new	free-order-payment-plugin.patch	7.52 KB

Status	File	Size
hidden	free-order-payment-plugin.patch	6.42 KB

Status	File	Size
new	check-payment-plugin.patch	11.52 KB

Status	File	Size
hidden	free-order-payment-plugin.patch	7.52 KB

Status	File	Size
new	payment-pack-plugins.patch	29.43 KB

Status	File	Size
new	payment-pack-plugins.patch	34.77 KB

Status	File	Size
hidden	check-payment-plugin.patch	11.52 KB
hidden	payment-pack-plugins.patch	29.43 KB

Status	File	Size
new	cod-payment-plugin.patch	15.81 KB

Status	File	Size
hidden	payment-pack-plugins.patch	34.77 KB

Status	File	Size
new	uc_payment_method_list-cleanup.patch	9.33 KB

Status	File	Size
hidden	cod-payment-plugin.patch	15.81 KB

Status	File	Size
new	checkout-pane-plugin-manager.patch	17.48 KB

Status	File	Size
hidden	uc_payment_method_list-cleanup.patch	9.33 KB

Status	File	Size
new	checkout-pane-plugin-manager.patch	18.49 KB

Status	File	Size
hidden	checkout-pane-plugin-manager.patch	17.48 KB

Comment #24

31 December 2013 at 01:23

The last submitted patch, 22: checkout-pane-plugin-manager.patch, failed testing.

Log in or register to post comments

Comment #25

31 December 2013 at 01:26

Status:

Needs review

» Needs work

The last submitted patch, 23: checkout-pane-plugin-manager.patch, failed testing.

Log in or register to post comments

Status	File	Size
new	checkout-pane-plugin-manager.patch	20.31 KB

Status	File	Size
hidden	checkout-pane-plugin-manager.patch	18.49 KB

Comment #27

6 January 2014 at 09:35

Status:

Needs review

» Needs work

The last submitted patch, 26: checkout-pane-plugin-manager.patch, failed testing.

Log in or register to post comments

Comment #28

longwave

he/him

English

UK

commented 7 January 2014 at 00:13

Status:

Needs work

» Needs review

26: checkout-pane-plugin-manager.patch queued for re-testing.

Previously failed due to a regression in core relating to UTF-8 characters caused by #1979468: ".active" from linkGenerator(), l() and theme_links() forces an upper limit of per-page caching for all content containing links.

Log in or register to post comments

Comment #29

7 January 2014 at 00:34

Status:

Needs review

» Needs work

The last submitted patch, 26: checkout-pane-plugin-manager.patch, failed testing.

Log in or register to post comments

Status	File	Size
new	checkout-pane-plugin-manager.patch	22.49 KB
new	interdiff.txt	5.39 KB

Status	File	Size
hidden	checkout-pane-plugin-manager.patch	20.31 KB

Comment #33

8 January 2014 at 09:07

Status:

Needs review

» Needs work

The last submitted patch, 32: checkout-pane-plugins.patch, failed testing.

Log in or register to post comments

Comment #35

10 January 2014 at 19:16

The last submitted patch, 34: drupal_add_css.patch, failed testing.

Log in or register to post comments

Comment #36

10 January 2014 at 19:16

Status:

Needs review

» Needs work

The last submitted patch, 34: checkout-pane-plugins-2.patch, failed testing.

Log in or register to post comments

Comment #38

12 January 2014 at 00:18

Status:

Needs review

» Needs work

The last submitted patch, 37: address-pane-plugin.patch, failed testing.

Log in or register to post comments

Comment #43

longwave

he/him

English

UK

commented 12 January 2014 at 12:22

simplify-uc_cart_complete_sale.patch queued for re-testing.

Log in or register to post comments

Comment #44

12 January 2014 at 12:37

The last submitted patch, simplify-uc_cart_complete_sale.patch, failed testing.

Log in or register to post comments

Comment #49

14 January 2014 at 01:01

Status:

Needs review

» Needs work

The last submitted patch, 48: twig-uc_payment_totals.patch, failed testing.

Log in or register to post comments

Comment #50

14 January 2014 at 01:00

The last submitted patch, 48: twig-uc_payment_totals.patch, failed testing.

Log in or register to post comments

Comment #61

22 January 2014 at 22:43

Status:

Needs review

» Needs work

The last submitted patch, 60: checkout-pane-plugin-config.patch, failed testing.

Log in or register to post comments

Comment #65

23 January 2014 at 01:19

The last submitted patch, 63: simplify-uc_cart_get_contents.patch, failed testing.

Log in or register to post comments

Comment #68

27 January 2014 at 15:17

The last submitted patch, 66: same-address-pane-config.patch, failed testing.

Log in or register to post comments

Comment #71

5 February 2014 at 08:33

Status:

Needs review

» Needs work

The last submitted patch, 70: line-item-cmi.patch, failed testing.

Log in or register to post comments

Comment #73

longwave

he/him

English

UK

commented 11 February 2014 at 19:08

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #74

11 February 2014 at 19:14

Status:

Needs review

» Needs work

The last submitted patch, 72: remove-hook-forms.patch, failed testing.

Log in or register to post comments

Comment #75

longwave

he/him

English

UK

commented 12 February 2014 at 08:06

Status:

Needs work

» Needs review

72: remove-hook-forms.patch queued for re-testing.

Log in or register to post comments

Comment #76

12 February 2014 at 08:10

Status:

Needs review

» Needs work

The last submitted patch, 72: remove-hook-forms.patch, failed testing.

Log in or register to post comments

Comment #77

12 February 2014 at 08:10

The last submitted patch, 72: remove-hook-forms.patch, failed testing.

Log in or register to post comments

Comment #79

12 February 2014 at 08:19

Status:

Needs review

» Needs work

The last submitted patch, 78: remove-hook-forms.patch, failed testing.

Log in or register to post comments

Comment #80

longwave

he/him

English

UK

commented 12 February 2014 at 09:20

Testbot is broken for contrib: #2194271: D8: Make testbot check out projects into top-level /modules directory

Log in or register to post comments

Comment #82

14 February 2014 at 11:09

Status:

Needs review

» Needs work

The last submitted patch, 81: remove-hook-forms.patch, failed testing.

Log in or register to post comments

Comment #83

longwave

he/him

English

UK

commented 14 February 2014 at 12:00

Status:

Needs work

» Needs review

81: remove-hook-forms.patch queued for re-testing.

Log in or register to post comments

Comment #84

14 February 2014 at 12:18

Status:

Needs review

» Needs work

The last submitted patch, 81: remove-hook-forms.patch, failed testing.

Log in or register to post comments

Comment #88

16 February 2014 at 13:49

Status:

Needs review

» Needs work

The last submitted patch, 87: add-to-cart-form.patch, failed testing.

Log in or register to post comments

Comment #90

longwave

he/him

English

UK

commented 16 February 2014 at 19:18

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #93

17 February 2014 at 17:51

Status:

Needs review

» Needs work

The last submitted patch, 92: country-cmi.patch, failed testing.

Log in or register to post comments

Comment #95

17 February 2014 at 18:17

Status:

Needs review

» Needs work

The last submitted patch, 94: country-cmi.patch, failed testing.

Log in or register to post comments

Comment #97

longwave

he/him

English

UK

commented 20 February 2014 at 19:16

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #98

20 February 2014 at 20:54

Status:

Needs review

» Needs work

The last submitted patch, 96: chasing-head.patch, failed testing.

Log in or register to post comments

Comment #100

21 February 2014 at 00:46

Status:

Needs review

» Needs work

The last submitted patch, 99: chasing-head.patch, failed testing.

Log in or register to post comments

Comment #102

21 February 2014 at 21:09

Status:

Needs review

» Needs work

The last submitted patch, 101: chasing-head.patch, failed testing.

Log in or register to post comments

Comment #105

22 February 2014 at 14:12

Status:

Needs review

» Needs work

The last submitted patch, 104: country-cmi.patch, failed testing.

Log in or register to post comments

Comment #108

5 March 2014 at 23:45

Status:

Needs review

» Needs work

The last submitted patch, 107: country-cmi.patch, failed testing.

Log in or register to post comments

Comment #111

17 March 2014 at 09:27

Status:

Needs review

» Needs work

The last submitted patch, 110: product-base-fields.patch, failed testing.

Log in or register to post comments

Comment #113

17 March 2014 at 19:17

Status:

Needs review

» Needs work

The last submitted patch, 112: product-base-fields.patch, failed testing.

Log in or register to post comments

Comment #115

19 March 2014 at 09:25

Status:

Needs review

» Needs work

The last submitted patch, 114: product-base-fields.patch, failed testing.

Log in or register to post comments

Comment #117

longwave

he/him

English

UK

commented 19 March 2014 at 18:58

2 files were hidden/shown/deleted

Status	File	Size
hidden	country-cmi.patch	743.4 KB
hidden	country-cmi.patch	749.27 KB

Moved country CMI stuff to #1214492: Add CRUD API for countries

Log in or register to post comments

Comment #118

19 March 2014 at 20:09

Status:

Needs review

» Needs work

The last submitted patch, 116: product-base-fields.patch, failed testing.

Log in or register to post comments

Comment #121

22 March 2014 at 13:47

Status:

Needs review

» Needs work

The last submitted patch, 120: remove-hook_uc_order.patch, failed testing.

Log in or register to post comments

Comment #124

25 March 2014 at 18:58

Status:

Needs review

» Needs work

The last submitted patch, 123: uc_line_items_calculate.patch, failed testing.

Log in or register to post comments

Comment #127

25 March 2014 at 19:22

The last submitted patch, 125: uc_line_items_calculate.patch, failed testing.

Log in or register to post comments

Comment #128

25 March 2014 at 19:25

Status:

Needs review

» Needs work

The last submitted patch, 126: uc_order_load_line_items.patch, failed testing.

Log in or register to post comments

Comment #129

longwave

he/him

English

UK

commented 26 March 2014 at 14:29

125: uc_line_items_calculate.patch queued for re-testing.

Log in or register to post comments

Comment #130

longwave

he/him

English

UK

commented 26 March 2014 at 14:29

Status:

Needs work

» Needs review

126: uc_order_load_line_items.patch queued for re-testing.

Log in or register to post comments

Comment #131

26 March 2014 at 14:33

Status:

Needs review

» Needs work

The last submitted patch, 126: uc_order_load_line_items.patch, failed testing.

Log in or register to post comments

Comment #135

26 March 2014 at 18:06

Status:

Needs review

» Needs work

The last submitted patch, 134: filter_xss.patch, failed testing.

Log in or register to post comments

Comment #137

longwave

he/him

English

UK

commented 27 March 2014 at 08:01

136: deprecated_functions.patch queued for re-testing.

Log in or register to post comments

Comment #141

20 July 2014 at 12:14

Status:

Needs review

» Needs work

The last submitted patch, 140: remove-hook_uc_order.patch, failed testing.

Log in or register to post comments

Comment #143

longwave

he/him

English

UK

commented 20 July 2014 at 18:45

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #145

7 August 2014 at 22:00

Status:

Needs review

» Needs work

The last submitted patch, 144: uc_store-twig.patch, failed testing.

Log in or register to post comments

Comment #151

tr commented 15 July 2015 at 21:31

Status	File	Size
new	entity-api-2.patch	9.05 KB

More use of entity API.

@longwave: This is a patch I had in progress from last week. It looks like it conflicts with #150 only in a few lines in uc_order.module and uc_order.order_pane.inc.

Log in or register to post comments

Comment #154

16 July 2015 at 00:14

The last submitted patch, 151: entity-api-2.patch, failed testing.

Log in or register to post comments

Comment #155

16 July 2015 at 00:22

Status:

Needs review

» Needs work

The last submitted patch, 153: uc_store-twig.patch, failed testing.

Log in or register to post comments

Comment #156

tr commented 16 July 2015 at 02:31

Status:

Needs work

» Needs review

Status	File	Size
new	entity-api-3.patch	7.31 KB

Same as #151, with conflicts removed.

Log in or register to post comments

Comment #157

longwave

he/him

English

UK

commented 16 July 2015 at 20:59

@TR: Is there a reason you are fully qualifying class names instead of adding "use" statements and then only having the short names in code? Core and the coding standards use the latter, and I find the short names more readable - especially when it comes to avoiding long line lengths.

Log in or register to post comments

Comment #158

longwave

he/him

English

UK

commented 16 July 2015 at 21:16

Status	File	Size
new	uc_store-twig.patch	4.68 KB

10 files were hidden/shown/deleted

Status	File	Size
hidden	uc_store-twig.patch	4.48 KB
hidden	hide-zero-weight-dimensions.patch	3.62 KB
hidden	entity-api-insteadof-db_query.patch	10.87 KB
hidden	payment-settings-metadata.patch	8.46 KB
hidden	entity_create.patch	5.19 KB
hidden	entity_load.patch	6.13 KB
hidden	entity-api-2.patch	9.05 KB
hidden	uc_order_load.patch	18.62 KB
hidden	uc_store-twig.patch	4.65 KB
hidden	entity-api-3.patch	7.31 KB

Log in or register to post comments

Comment #159

longwave

he/him

English

UK

commented 16 July 2015 at 21:34

Status	File	Size
new	same-address-pane-config.patch	4.2 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	same-address-pane-config.patch	4.24 KB

Log in or register to post comments

Comment #160

16 July 2015 at 21:49

Status:

Needs review

» Needs work

The last submitted patch, 159: same-address-pane-config.patch, failed testing.

Log in or register to post comments

Comment #161

longwave

he/him

English

UK

commented 16 July 2015 at 21:53

Status:

Needs work

» Needs review

Status	File	Size
new	same-address-pane-config.patch	4.1 KB

2 files were hidden/shown/deleted

Status	File	Size
hidden	uc_store-twig.patch	4.68 KB
hidden	same-address-pane-config.patch	4.2 KB

Log in or register to post comments

Comment #162

tr commented 16 July 2015 at 22:03

@TR: Is there a reason you are fully qualifying class names instead of adding "use" statements and then only having the short names in code? Core and the coding standards use the latter, and I find the short names more readable - especially when it comes to avoiding long line lengths.

If the class is only used once or twice in a file, which is typically what we do, I find it easier/clearer to use the fully qualified name. That's also the way I treat abbreviations/acronyms in general writing. But I don't care much either way, so its fine with me if you want to add the use statement.

Log in or register to post comments

Comment #163

tr commented 21 July 2015 at 05:28

Status	File	Size
new	status.patch	15.96 KB

Log in or register to post comments

Comment #164

longwave

he/him

English

UK

commented 21 July 2015 at 07:56

         // The state cannot be changed if the status is locked.
         if (!$form['#locked'][$key]) {
-          $status->state = $value['state'];
+          $status->setState($value['state']);
         }

Should OrderStatus::setState() (and delete()) handle this check, throwing exceptions where necessary?

Log in or register to post comments

Comment #165

tr commented 21 July 2015 at 08:19

Yes, sounds like a good idea, so we won't have to rely on the caller of those functions to check the locked property.

Log in or register to post comments

Comment #166

tr commented 22 July 2015 at 05:25

Status	File	Size
new	country.patch	9.37 KB

Log in or register to post comments

Comment #167

longwave

he/him

English

UK

commented 22 July 2015 at 21:51

Status	File	Size
new	order-status-delete.patch	3.73 KB

Log in or register to post comments

Comment #168

22 July 2015 at 22:00

Status:

Needs review

» Needs work

The last submitted patch, 167: order-status-delete.patch, failed testing.

Log in or register to post comments

Comment #169

tr commented 22 July 2015 at 22:35

Can you also add a test for deleting a locked status, to check that the exception is thrown when expected?

Log in or register to post comments

Comment #170

23 July 2015 at 13:28

Status:

Needs work

» Needs review

longwave queued 167: order-status-delete.patch for re-testing.

Log in or register to post comments

Comment #171

longwave

he/him

English

UK

commented 24 July 2015 at 14:45

Status	File	Size
new	order-status-delete.patch	5.58 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	order-status-delete.patch	3.73 KB

Added a unit test for that, our first one I think!

Log in or register to post comments

Comment #172

longwave

he/him

English

UK

commented 24 July 2015 at 14:46

Status	File	Size
new	uc_order_status_options_list.patch	8.93 KB

Log in or register to post comments

Comment #173

longwave

he/him

English

UK

commented 24 July 2015 at 14:48

Status	File	Size
new	order-view.patch	6.59 KB

Log in or register to post comments

Comment #174

24 July 2015 at 16:44

The last submitted patch, 171: order-status-delete.patch, failed testing.

Log in or register to post comments

Comment #175

24 July 2015 at 16:50

longwave queued 171: order-status-delete.patch for re-testing.

Log in or register to post comments

Comment #176

24 July 2015 at 16:55

The last submitted patch, 171: order-status-delete.patch, failed testing.

Log in or register to post comments

Comment #177

longwave

he/him

English

UK

commented 24 July 2015 at 16:58

Status	File	Size
new	order-status-delete.patch	5.12 KB

4 files were hidden/shown/deleted

Status	File	Size
hidden	same-address-pane-config.patch	4.1 KB
hidden	order-status-delete.patch	5.58 KB
hidden	uc_order_status_options_list.patch	8.93 KB
hidden	order-view.patch	6.59 KB

Log in or register to post comments

Comment #178

24 July 2015 at 17:56

Status:

Needs review

» Needs work

The last submitted patch, 177: order-status-delete.patch, failed testing.

Log in or register to post comments

Comment #179

tr commented 28 July 2015 at 01:48

Status	File	Size
new	inject.patch	111.31 KB

Log in or register to post comments

Comment #180

tr commented 28 July 2015 at 04:00

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #181

longwave

he/him

English

UK

commented 5 August 2015 at 19:42

Status	File	Size
new	settings-to-config.patch	57.01 KB

Log in or register to post comments

Comment #182

5 August 2015 at 19:51

Status:

Needs review

» Needs work

The last submitted patch, 181: settings-to-config.patch, failed testing.

Log in or register to post comments

Comment #183

5 August 2015 at 19:52

longwave queued 177: order-status-delete.patch for re-testing.

Log in or register to post comments

Comment #184

longwave

he/him

English

UK

commented 5 August 2015 at 20:04

Status	File	Size
new	settings-to-config.patch	58.11 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	settings-to-config.patch	57.01 KB

Log in or register to post comments

Comment #185

5 August 2015 at 20:06

The last submitted patch, 177: order-status-delete.patch, failed testing.

Log in or register to post comments

Comment #186

longwave

he/him

English

UK

commented 5 August 2015 at 20:09

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #187

5 August 2015 at 20:09

longwave queued 177: order-status-delete.patch for re-testing.

Log in or register to post comments

Comment #188

tr commented 16 August 2015 at 05:32

Status	File	Size
new	format.patch	13.1 KB

Remove format_string().

Log in or register to post comments

Comment #189

16 August 2015 at 05:40

Status:

Needs review

» Needs work

The last submitted patch, 188: format.patch, failed testing.

Log in or register to post comments

Comment #190

tr commented 17 August 2015 at 20:19

Status:

Needs work

» Needs review

Status	File	Size
new	t.patch	20.04 KB

Log in or register to post comments

Comment #191

17 August 2015 at 20:33

Status:

Needs review

» Needs work

The last submitted patch, 190: t.patch, failed testing.

Log in or register to post comments

Comment #192

tr commented 17 August 2015 at 20:52

Status:

Needs work

» Needs review

Status	File	Size
new	t.patch	20.06 KB

Log in or register to post comments

Comment #193

17 August 2015 at 20:54

Status:

Needs review

» Needs work

The last submitted patch, 192: t.patch, failed testing.

Log in or register to post comments

Comment #194

tr commented 17 August 2015 at 21:07

Status:

Needs work

» Needs review

Status	File	Size
new	t.patch	20.05 KB

Log in or register to post comments

Comment #195

longwave

he/him

English

UK

commented 2 September 2015 at 17:45

Status	File	Size
new	modern-store-report.patch	2.22 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	settings-to-config.patch	58.11 KB

Log in or register to post comments

Comment #196

2 September 2015 at 21:40

Status:

Needs review

» Needs work

The last submitted patch, 195: modern-store-report.patch, failed testing.

Log in or register to post comments

Comment #197

longwave

he/him

English

UK

commented 3 September 2015 at 09:00

Status:

Needs work

» Needs review

Status	File	Size
new	modern-store-report.patch	3 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	modern-store-report.patch	2.22 KB

Log in or register to post comments

Comment #198

6 September 2015 at 18:51

longwave queued 197: modern-store-report.patch for re-testing.

Log in or register to post comments

Comment #199

longwave

he/him

English

UK

commented 9 September 2015 at 12:50

Status	File	Size
new	improve-address-class.patch	4.05 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	modern-store-report.patch	3 KB

Log in or register to post comments

Comment #200

9 September 2015 at 12:57

Status:

Needs review

» Needs work

The last submitted patch, 199: improve-address-class.patch, failed testing.

Log in or register to post comments

Comment #201

9 September 2015 at 13:00

The last submitted patch, 199: improve-address-class.patch, failed testing.

Log in or register to post comments

Comment #202

9 September 2015 at 13:00

The last submitted patch, 199: improve-address-class.patch, failed testing.

Log in or register to post comments

Comment #203

9 September 2015 at 16:11

The last submitted patch, 199: improve-address-class.patch, failed testing.

Log in or register to post comments

Comment #204

16 September 2015 at 22:44

Status:

Needs work

» Needs review

longwave queued 199: improve-address-class.patch for re-testing.

Log in or register to post comments

Comment #205

17 September 2015 at 20:52

longwave queued 199: improve-address-class.patch for re-testing.

Log in or register to post comments

Comment #206

longwave

he/him

English

UK

commented 17 September 2015 at 22:30

Status	File	Size
new	checkout-quote-pane.patch	12.2 KB

Log in or register to post comments

Comment #207

longwave

he/him

English

UK

commented 21 September 2015 at 21:20

Status	File	Size
new	remove-checkout-pane-hook.patch	12.41 KB

2 files were hidden/shown/deleted

Status	File	Size
hidden	improve-address-class.patch	4.05 KB
hidden	checkout-quote-pane.patch	12.2 KB

Log in or register to post comments

Comment #208

21 September 2015 at 21:38

The last submitted patch, 206: checkout-quote-pane.patch, failed testing.

Log in or register to post comments

Comment #209

22 September 2015 at 08:07

Status:

Needs review

» Needs work

The last submitted patch, 207: remove-checkout-pane-hook.patch, failed testing.

Log in or register to post comments

Comment #210

longwave

he/him

English

UK

commented 6 October 2015 at 22:30

Status:

Needs work

» Needs review

Status	File	Size
new	fix-catalog-taxonomy-field.patch	1.61 KB

Log in or register to post comments

Comment #211

6 October 2015 at 22:38

Status:

Needs review

» Needs work

The last submitted patch, 210: fix-catalog-taxonomy-field.patch, failed testing.

Log in or register to post comments

Comment #212

6 October 2015 at 22:38

The last submitted patch, 210: fix-catalog-taxonomy-field.patch, failed testing.

Log in or register to post comments

Comment #213

6 October 2015 at 23:43

The last submitted patch, 210: fix-catalog-taxonomy-field.patch, failed testing.

Log in or register to post comments

Comment #214

longwave

he/him

English

UK

commented 8 October 2015 at 22:06

Status:

Needs work

» Needs review

Status	File	Size
new	no-rules.patch	300 bytes

Log in or register to post comments

Comment #215

8 October 2015 at 22:14

Status:

Needs review

» Needs work

The last submitted patch, 214: no-rules.patch, failed testing.

Log in or register to post comments

Comment #216

8 October 2015 at 22:16

The last submitted patch, 214: no-rules.patch, failed testing.

Log in or register to post comments

Comment #217

8 October 2015 at 22:42

longwave queued 210: fix-catalog-taxonomy-field.patch for re-testing.

Log in or register to post comments

Comment #218

longwave

he/him

English

UK

commented 21 October 2015 at 22:19

Status:

Needs work

» Needs review

Status	File	Size
new	uc_role-postgres.patch	575 bytes

Log in or register to post comments

Comment #219

tr commented 5 November 2015 at 19:02

Status	File	Size
new	url-deprecated.patch	47.4 KB

\Drupal::url() is newly deprecated.

Log in or register to post comments

Comment #220

6 November 2015 at 08:26

Status:

Needs review

» Needs work

The last submitted patch, 219: url-deprecated.patch, failed testing.

Log in or register to post comments

Comment #221

longwave

he/him

English

UK

commented 29 November 2015 at 00:01

Status:

Needs work

» Needs review

Status	File	Size
new	unused-use.patch	10.07 KB

Log in or register to post comments

Comment #222

longwave

he/him

English

UK

commented 4 December 2015 at 15:32

Status:

Needs review

» Closed (fixed)

I think it's time to close this one out, as with dreditor installed I can barely load the page any more. Let's use individual issues where possible or maybe a new patch testing issue for small fixes.

Log in or register to post comments

Comment #223

tr commented 1 January 2016 at 08:10

Component:

Code

» Tests

Log in or register to post comments

Comment #224

tr commented 15 October 2016 at 02:35

Status	File	Size
new	2160791-224.patch	580 bytes

Patch for uc_order uninstall.

Log in or register to post comments

Title:	Patch testing issue	» [D8] Patch testing issue
Issue summary:	View changes

[D8] Patch testing issue

Comments