Closed (fixed)
Project:
Superfish Dropdown Menu
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Dec 2013 at 11:17 UTC
Updated:
2 Jan 2019 at 19:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
helmo commentedComment #2
ordermind commentedThe dev patch looks weird, you're actually trying to translate a boolean. I'm attaching a new patch for dev that is tested and works. $output['subject'] appears to come from the menu title so you should be able to talk to i18n_menu to get the translated menu title if present, but in the meantime this should be fine.
Comment #3
Caspa commentedThanks @helmo. I used the patch superfish-7.x-1.9-2160409-1.patch in #1 and it works very well.
the site is in English an dutch (default) with the module l10n_update installed. Nice job!
Comment #4
Caspa commentedComment #5
leksat commentedI have found 3 sources from where the title can come:
1.
superfish_small*_*variables2. menu item
3. menu title
In my opinion, the text coming from
superfish_small*_*variables should be translated via the i18n_variable module. The translation should be possible if there is a hook_variable_info() implementation. My patch does not provide it.Menu title/item translations are normally handled my the i18n_menu module. If the title comes from a menu item, the translation is loaded automatically in menu_link_load().
My patch handles the third case, when the title comes from the menu title.
Comment #7
mehrpadin commentedHey,
Patch applied, please check, thanks.
Comment #9
hstoellinger commentedHello,
I still have the problem that - using "smallscreen" and an accordion menu for viewports less than 560px - the menu-title is not translated. My default language is German, but the site is multilingual (+ English and Italian). My menu title is "Menü" (u-Umlaut) in German and should be "menu" in both the other languages. I have looked at your patch for the superfish.module. However, I see that MY superfish module (version 8.x-1.3) looks very different, The patch seems to be for version 7.x.... Eg., there is no SELECT statement at all in MY superfish.module, and it is MUCH smaller.
I also see that - in the "smallscreen" case - the "normal" (non-accordion) menu is displayed for a second or so before the Accordion-style menu gets displayed. This surely cannot be "works as designed"! Any ideas?
Is there a chance for me to solve these issues?
Regards
H. Stoellinger
Austria