It was discussed and decided on #2081945: [Policy, no patch] Reintroduce 'private' visibility to object-oriented code. that we no longer want to have a guideline in the Drupal coding standards saying basically that "private stuff on classes is bad".

Apparently, Coder has a review rule that says "private stuff on classes is bad".

It needs to be removed.

CommentFileSizeAuthor
#1 coder-allow-private-class-members-2159567.patch2.95 KBDarren Oh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented
Status: Active » Needs review
FileSize
coder-allow-private-class-members-2159567.patch2.95 KB
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Component: Review/Rules » Coder Sniffer
Status: Needs review » Fixed

Fixed the comments a bit in good.php and committed the patch, thanks! http://drupalcode.org/project/coder.git/commit/651d34c

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.